Opened 9 years ago

Closed 9 years ago

#219 closed defect (fixed)

(review) bindctl rejects IPv6 addresses

Reported by: jinmei Owned by: UnAssigned
Priority: high Milestone: 04. 2nd Incremental Release: Early Adopters
Component: ~bind-ctl (obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

When I tried to trigger xfr using IPv6 via bindctl, I saw:

> Xfrin retransfer master = 2001:4f8:3:36::162 zone_name = jinmei.org
Error!  Parameter format error, it should like 'key = value'

This is because IPv6 addresses are not recognized as a "parameter value". The attached simple patch fixes this. Please reivew. I hope this will be included in the next release.

Aside from the immediate problem, I have some additional comments on the current behavior:

  • I don't think it makes sense to expect a specific format as acceptable "parameter values" as it's very likely that we add more variations of parameters. I believe the command parser should only do minimal check like "parameter value is a sequecne of non space characters", "quoted string" is an string surrounded by quotation marks (such marks themselves can be part of the string in an escaped form).
  • I susepct "quota_str" and "QUOTA_PATTERN" are typo, and should be "quoted"/"QUOATED"
  • the error message is unfirendly. it should at least identify which part of the input causes the error.

Subtickets

Attachments (1)

bindctl.diff (1.1 KB) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:2 follow-up: Changed 9 years ago by jreed

This fix is fine (I read but didn't test). Maybe fix error message while there ("it should be like" to add "be").

As for your other comments, maybe other tickets or keep this open even after you commit the regex fix and error message improvement.

comment:3 in reply to: ↑ 2 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to jreed:

This fix is fine (I read but didn't test). Maybe fix error message while there ("it should be like" to add "be").

Okay, committed. Also applied the suggestion on the error message (r2025).

As for your other comments, maybe other tickets or keep this open even after you commit the regex fix and error message improvement.

Yes. I'll open a separate ticket. Closing this one.

Note: See TracTickets for help on using tickets.