Opened 8 years ago

Closed 8 years ago

#2182 closed enhancement (fixed)

Simplify RBTree::deleteHelper() and make it non-recursive

Reported by: muks Owned by: muks
Priority: low Milestone: Sprint-20120807
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0.43 Internal?: no

Description

The code in RBTree::deleteHelper() is more complicated than it needs to be. This is a cleanup, that also makes it non-recursive by iteratively walking the trees.

Subtickets

Change History (7)

comment:1 Changed 8 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from new to reviewing

trac2182 is up for review.

I'd like it to be moved to the current sprint as it's a smallish change which is ready for review. It's better this goes into the tree soon when it's cleanly merge-able.

comment:2 Changed 8 years ago by muks

  • Summary changed from Simplify and make RBTree::deleteHelper() non-recursive to Simplify RBTree::deleteHelper() and make it non-recursive

comment:3 Changed 8 years ago by muks

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120807

Moving to current sprint after asking Jelte.

comment:4 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:5 Changed 8 years ago by vorner

  • Owner changed from vorner to muks

Hello

It looks simple enough. I think it can be merged.

comment:6 Changed 8 years ago by vorner

  • Total Hours changed from 0 to 0.43

comment:7 Changed 8 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master (this got fast-forwarded because nothing else went into master after this branch was created, so there's no merge commit):

* 862b15f [2182] Simplify code further
* 823c4a9 [2182] Simplify RBTree::deleteHelper() and also make it non-recursive

Resolving as fixed. Thank you for the review Michal.

Note: See TracTickets for help on using tickets.