Opened 9 years ago

Closed 9 years ago

#218 closed defect (fixed)

(review) a regression in xfrin: it can't communicate with a remote server.

Reported by: jinmei Owned by: jinmei
Priority: high Milestone: 04. 2nd Incremental Release: Early Adopters
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Now that each xfrin connection thread has its own socket map (which is itself the right thing), we need to pass that map to asyncore.loop(). Otherwise the loop would use the global map and fail to keep track of the connection.

The fix is trivial. Please review. This must be included in the release.

Subtickets

Attachments (1)

xfrin.diff (814 bytes) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Status changed from new to reviewing

comment:2 in reply to: ↑ description Changed 9 years ago by jinmei

Replying to jinmei:

Now that each xfrin connection thread has its own socket map (which is itself the right thing), we need to pass that map to asyncore.loop(). Otherwise the loop would use the global map and fail to keep track of the connection.

The fix is trivial. Please review. This must be included in the release.

Reminder: this is critical. Without this change xfrin doesn't work at atll (I broke it, sorry). I'm quite sure this patch is correct and believe it's critical, so I'm going to merge this to trunk even if I can't get it reviewed before the freeze deadline. In that case I'll keep this ticket open so that we can still get it reviewed.

comment:3 Changed 9 years ago by shane

  • Owner changed from UnAssigned to jinmei

Change seems straightforward and makes sense. If not already merged, go for it.

comment:4 Changed 9 years ago by shane

  • Resolution set to fixed
  • Status changed from reviewing to closed

This has been committed. Closing ticket.

Note: See TracTickets for help on using tickets.