Opened 7 years ago

Closed 7 years ago

#2169 closed defect (fixed)

build using log4cplus 1.1.0

Reported by: jreed Owned by: muks
Priority: medium Milestone: Sprint-20120807
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0.61 Internal?: no

Description

log4cplus is currently in a release candidate stage for 1.1.0.

John Lumby provided some patches for bind10's lib/log:
https://lists.isc.org/pipermail/bind10-dev/2012-June/003541.html
(see entire thread)

Subtickets

Change History (10)

comment:1 Changed 7 years ago by jreed

  • Sub-Project changed from DNS to Core

The patch from https://lists.isc.org/pipermail/bind10-dev/2012-June/003547.html does not work with log4cplus 1.0.4:

libtool: compile:  /home/reed/bin/ccache-c++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/lib -I../../../src/lib -I/usr/pkg/include -DTOP_BUILDDIR=\"/home/reed/work/isc/bind10/git/bind10\" -I/usr/pkg/include -DOS_BSD -I../../../ext/asio -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wno-unused-parameter -g -O2 -MT liblog_la-logger_level_impl.lo -MD -MP -MF .deps/liblog_la-logger_level_impl.Tpo -c logger_level_impl.cc  -fPIC -DPIC -o .libs/liblog_la-logger_level_impl.o
logger_level_impl.cc: In static member function 'static void isc::log::LoggerLevelImpl::init()':
logger_level_impl.cc:217: error: invalid conversion from 'const log4cplus::tstring& (*)(log4cplus::LogLevel)' to 'log4cplus::tstring (*)(log4cplus::LogLevel)'
logger_level_impl.cc:217: error:   initializing argument 1 of 'void log4cplus::LogLevelManager::pushToStringMethod(log4cplus::tstring (*)(log4cplus::LogLevel))'
*** Error code 1

comment:2 Changed 7 years ago by jelte

  • Estimated Difficulty changed from 0 to 3

comment:3 Changed 7 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120807

comment:4 Changed 7 years ago by muks

  • Owner set to muks
  • Status changed from new to assigned

Picking

comment:5 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

Up for review.

comment:6 Changed 7 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:7 Changed 7 years ago by vorner

  • Owner changed from vorner to muks

It builds both on the new and old version for me. The code looks OK too. But maybe there should be a changelog entry for this. Would you add one and merge, please?

Thank you

comment:8 Changed 7 years ago by vorner

  • Total Hours changed from 0 to 0.61

comment:9 Changed 7 years ago by muks

The following ChangeLog? entry has been added:

+456.   [bug]           muks
+       BIND 10 now compiles against log4cplus-1.1.0 (RC releases)
+       also. Thanks to John Lumby for sending a patch.
+       (Trac #2169, git 7d7e5269d57451191c0aef1b127d292d3615fe2c)

comment:10 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master in commit 7d7e5269d57451191c0aef1b127d292d3615fe2c:

* 3378f9b [2169] Fix tree for changes in log4cplus 1.1.0

Also added:

* 9e4e068 [2169] Update ChangeLog

Resolving as fixed. Thank you for review vorner.

Note: See TracTickets for help on using tickets.