Opened 7 years ago

Closed 6 years ago

#2168 closed defect (fixed)

deprecate matchWireData in dns/tests

Reported by: jinmei Owned by: muks
Priority: medium Milestone: bind10-1.2-release-freeze
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

and use isc::util::unittests::matchWireData() throughout the
implementation (note that the ordering of "expected" and "actual" is
reversed).

This ticket addresses one point of #892.

Subtickets

Change History (10)

comment:1 Changed 7 years ago by jinmei

  • Milestone set to Next-Sprint-Proposed

comment:2 Changed 7 years ago by jinmei

  • Milestone set to Next-Sprint-Proposed

comment:3 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Status changed from new to reviewing

Up for review.

comment:4 Changed 6 years ago by kean

  • Owner changed from UnAssigned to kean

comment:5 Changed 6 years ago by kean

  • Owner changed from kean to muks

This looks fine to me. Please go ahead and merge and close.

comment:6 Changed 6 years ago by muks

  • Owner changed from muks to kean

master branch has moved on and other parts of the code needed changes. Please pull trac2168 and re-review.

comment:7 Changed 6 years ago by stephen

  • Owner changed from kean to muks

Reviewed commit 195af9e40f0715d241af51c704faa4fea6a96839 (in particular, the differences between it and commit 8b413f0b6f0325a124af6e170e9c96016d032007, where this branch was first merged into master).

All OK, please merge.

comment:8 Changed 6 years ago by muks

  • Owner changed from muks to stephen

This needed another merge from the master branch. Please pull trac2168 and re-review (it is just the merge conflict resolution fixes).

comment:9 Changed 6 years ago by stephen

  • Owner changed from stephen to muks

Reviewed the files reported as merge conflicts in commit e07be6f5511f491c1575b289b8ca288434664673:

  • src/lib/dns/tests/rdata_nsec3param_like_unittest.cc
  • src/lib/dns/tests/rdata_nsecbitmap_unittest.cc

Both look good, OK to merge.

comment:10 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit fe4183783d075bd2ac2aef3d7dc6e3de999d8589:

* e07be6f Merge branch 'master' into trac2168
* 195af9e [2168] Remove more cases of UnitTestUtil::matchWireData (merged from master)
* 8b413f0 Merge branch 'master' into trac2168
* f56a2d4 [2168] Fix more unittests
* 8f422c2 [2168] Remove UnitTestUtil::matchWireData()
* 1d34831 [2168] Remove use of UnitTestUtil::matchWireData() in dns/tests/

Resolving as fixed. Thank you for the reviews Stephen.

Note: See TracTickets for help on using tickets.