Opened 7 years ago

Closed 7 years ago

#2123 closed defect (fixed)

New suggestions by cppcheck 1.55

Reported by: vorner Owned by: vorner
Priority: medium Milestone: Sprint-20120731
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0.89 Internal?: no

Description

Again, my OS got a new version of the cppcheck tool and it discovered some new issues, mostly style.

As they would be mostly trivial to solve, I'm proposing this to next-sprint-proposed.

Here they are:

src/lib/config/module_spec.cc:479: check_fail: The scope of the variable 'found' can be reduced (style,variableScope)
src/lib/log/tests/logger_name_unittest.cc:35: check_fail: Variable 'name_' is assigned in constructor body. Consider to perform initalization in initialization list. (performance,useInitializationList)
src/lib/server_common/tests/socket_requestor_test.cc:453: check_fail: Function parameter 'data' should be passed by reference. (performance,passedByValue)
src/lib/util/filename.cc:37: check_fail: The scope of the variable 'dir_present' can be reduced (style,variableScope)
src/lib/util/strutil.cc:42: check_fail: The scope of the variable 'blanks' can be reduced (style,variableScope)

Subtickets

Change History (5)

comment:1 Changed 7 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120731

comment:2 Changed 7 years ago by vorner

  • Owner set to vorner
  • Status changed from new to accepted

comment:3 Changed 7 years ago by vorner

  • Owner changed from vorner to UnAssigned
  • Status changed from accepted to reviewing

Hello

It is ready for review. I think it is simple and it doesn't need any Changelog entry.

comment:4 Changed 7 years ago by muks

  • Owner changed from UnAssigned to vorner

Looks good to me. Please merge.

comment:5 Changed 7 years ago by vorner

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Total Hours changed from 0 to 0.89

Thank you, merged

Note: See TracTickets for help on using tickets.