Opened 7 years ago

Closed 7 years ago

#2121 closed enhancement (fixed)

Add isc.sysinfo.SysInfo implementation for OpenBSD

Reported by: muks Owned by: muks
Priority: medium Milestone: Sprint-20120717
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by muks)

Add OpenBSD implementation for isc.sysinfo.SysInfo?. This should also introduce a class of things common to BSD implementations.

This is a part of #2085.

Subtickets

Change History (7)

comment:1 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from new to reviewing

Up for review.

comment:2 Changed 7 years ago by muks

  • Description modified (diff)

comment:3 Changed 7 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:4 follow-up: Changed 7 years ago by jelte

  • Owner changed from jelte to muks

I don't see any obvious problems with the implementation, so I think it can be merged.

Do have a few more general questions/comments about the showtech:

  • Should we warn if any tool is not found (instead of just printing 'Unknown')? (i.e. Unknown (netstat not found), or just simply 'warning: netstat not found, for complete information, blah blah blah)
  • Regarding that unknown, i noticed it may forget to print some newlines if it reports unknowns :)

comment:5 in reply to: ↑ 4 Changed 7 years ago by muks

  • Owner changed from muks to jelte

Replying to jelte:

I don't see any obvious problems with the implementation, so I think it can be merged.

Do have a few more general questions/comments about the showtech:

  • Should we warn if any tool is not found (instead of just printing 'Unknown')? (i.e. Unknown (netstat not found), or just simply 'warning: netstat not found, for complete information, blah blah blah)
  • Regarding that unknown, i noticed it may forget to print some newlines if it reports unknowns :)

Done. It returns the warning messages now. I have changed the "Unknown" values to have newlines where applicable, to preserve formatting.

comment:6 Changed 7 years ago by jelte

  • Owner changed from jelte to muks

Nice :)

OK, looks good, go ahead

comment:7 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master in commit af3a7eee9a18263f41e0ea8b5f6e0e3e49c11714:

* a9e21b4 [2121] Address review comments
* 5255dd6 [2121] Fix member variable names
* b150718 [2121] Strip output of hostname so it doesn't contain newlines
* 42674a0 [2121] Add testcases for OpenBSD implementation of SysInfo
* 90792ad [2121] Rename class
* d474871 [2121] Add isc.sysinfo.SysInfo implementation for OpenBSD

Resolving as fixed. Thank you for the reviews Jelte.

Note: See TracTickets for help on using tickets.