Opened 7 years ago

Closed 7 years ago

#2120 closed defect (fixed)

1LLU is an illegal litteral

Reported by: fdupont Owned by: muks
Priority: medium Milestone: Sprint-20120731
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 1 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

in src/lib/dns/tests/rdata_tsig_unittest.cc there is an 1LLU litteral. Unfortunately it is not fully legal so at least one C++ compiler (MSVC) rejects it... Of course the correct version is 1ULL.
cf http://connect.microsoft.com/VisualStudio/feedback/details/308123/integral-literal-doesnt-support-llu-suffix for Microsoft reference to the standard (or how to not be liberal :-).

Subtickets

Change History (6)

comment:1 Changed 7 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120731

comment:2 Changed 7 years ago by muks

  • Owner set to muks
  • Status changed from new to assigned

Picking

comment:3 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

Up for review.

comment:4 Changed 7 years ago by jinmei

Looks okay. Please merge.

comment:5 Changed 7 years ago by jinmei

  • Owner changed from UnAssigned to muks

comment:6 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master in commit 9bedc5ab8526c5da673786e93025ebd42c63b597:

* f0775ce [2120] Update integer literal suffix to comply with c++98

Resolving as fixed. Thank you for the review Jinmei.

Note: See TracTickets for help on using tickets.