Opened 8 years ago

Closed 8 years ago

#2089 closed task (complete)

RBTree node flags update

Reported by: jinmei Owned by: jelte
Priority: medium Milestone: Sprint-20120731
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: scalable inmemory
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0.34 Internal?: no

Description

This is part of the big picture.

  • encode the node color in flags
  • introduce the "root" flag (only internally settable) to indicate a node is the root of a subtree. carefully implement and test it - it's not trivial as the property can change due to insertion/rotation

Subtickets

Change History (7)

comment:1 Changed 8 years ago by shane

  • Estimated Difficulty changed from 0 to 5

comment:2 Changed 8 years ago by jelte

  • Milestone set to Sprint-20120717

comment:3 Changed 8 years ago by jelte

  • Owner set to jelte
  • Status changed from new to assigned

comment:4 Changed 8 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from assigned to reviewing

Ready for review.

First few changes are (for) the addition of the red/black flag, last few for the subtree root nodes.

Didn't really know how to test these outside of adding it to the dumpTree() output and checking that, if the reviewer has a good idea, let me know :)

comment:5 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:6 Changed 8 years ago by vorner

  • Owner changed from vorner to jelte
  • Total Hours changed from 0 to 0.34

I noticed one small thing. In the dumpTree test, the << marks between the lines are unneeded ‒ C (and therefore C++) joins neighboring string literals during compilation to form one.

If you want to keep them then it is OK, I just find them unnecessary.

Even if you remove them, I don't think I need it to see it again, please merge it then.

Thank you

comment:7 Changed 8 years ago by jelte

  • Resolution set to complete
  • Status changed from reviewing to closed

ack, doh, removed them

thanks, merged, closing ticket

Note: See TracTickets for help on using tickets.