Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2084 closed enhancement (fixed)

ambiguous call to [boost::]bind

Reported by: fdupont Owned by:
Priority: medium Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

In src/lib/config/tests/ccsession_unittests.cc the 2 calls to bind() must be qualified (i.e., bind -> boost::bind).

Subtickets

Change History (4)

comment:1 follow-up: Changed 7 years ago by jinmei

Thanks for the report.

I don't know why 'using namespace boost' didn't work for identifying
the correct definition, but in any case I agree it's better not to
try to incorporate the entire boost namespace, and then qualifying
boost:: is a MUST.

This is so simple so I directly made the change on master and pushed
it. I'm closing the ticket.

comment:2 Changed 7 years ago by jinmei

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 in reply to: ↑ 1 Changed 7 years ago by fdupont

Replying to jinmei:

I don't know why 'using namespace boost' didn't work for identifying
the correct definition,

=> it works for the bind() system call but it seems bind() was proposed for the next STL so conflicts (i.e., it is the same problem than for shared_ptr).

but in any case I agree it's better not to

try to incorporate the entire boost namespace, and then qualifying

boost
is a MUST.

=> fully agree!

This is so simple so I directly made the change on master and pushed
it. I'm closing the ticket.

thanks (and if this reopens the ticket please reclose it as I don't know if I may...)

comment:4 Changed 7 years ago by shane

  • Milestone New Tasks deleted
Note: See TracTickets for help on using tickets.