Opened 7 years ago

Closed 7 years ago

#2033 closed defect (fixed)

remove ZoneFinder::findPreviousName()

Reported by: jinmei Owned by: jinmei
Priority: low Milestone: Sprint-20120703
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0.6 Internal?: no

Description

This method was somehow introduced but has never been used except for
tests (and it increases the cost of writing tests because we need to
define it just because the base class requires it). We should clean
it up.

Subtickets

Change History (8)

comment:1 Changed 7 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120619

comment:2 Changed 7 years ago by jelte

  • Priority changed from medium to low

comment:3 Changed 7 years ago by jinmei

trac2033 is ready for review. Should be straightforward.

I don't think we need a changelog for this - although it's a change
to the public API, realistically no one else should have been
using it. So it's essentially an internal refactoring.

comment:4 Changed 7 years ago by jinmei

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:5 Changed 7 years ago by muks

  • Owner changed from UnAssigned to muks

Picking for review

comment:6 follow-up: Changed 7 years ago by muks

  • Owner changed from muks to jinmei

It looks fine to me. Please go ahead and merge.

comment:7 in reply to: ↑ 6 Changed 7 years ago by jinmei

Replying to muks:

It looks fine to me. Please go ahead and merge.

Thanks for the review, merge done, closing.

comment:8 Changed 7 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Total Hours changed from 0 to 0.6
Note: See TracTickets for help on using tickets.