Opened 10 years ago

Closed 9 years ago

#198 closed defect (fixed)

loadzone allow optional origin and comment for $INCLUDE per RFC 1035

Reported by: jreed Owned by: jreed
Priority: medium Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: loadzone Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

This is for f2f task 86.

RFC 1035 shows:

$INCLUDE <file-name> [<domain-name>] [<comment>]

And says:

$INCLUDE inserts the named file into the current file, and may optionally specify a domain name that sets the relative domain name origin for the included file. $INCLUDE may also have a comment. Note that a $INCLUDE entry never changes the relative origin of the parent file, regardless of changes to the relative origin
made within the included file.

Subtickets

Change History (10)

comment:1 Changed 9 years ago by zhanglikun

  • Component changed from Unclassified to loadzone
  • Owner set to shentingting
  • Status changed from new to assigned

Tingting, I think you had added this feature in revision 1898. Please make sure.

comment:2 Changed 9 years ago by shentingting

  • Resolution set to fixed
  • Status changed from assigned to closed

The newest version supports this!

comment:3 Changed 9 years ago by shentingting

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry I closed the ticket by accident, reopen it to review.

comment:4 follow-up: Changed 9 years ago by jreed

  • Summary changed from loadzone allow optional origin and comment for $INCLUDE per RF5 1035 to loadzone allow optional origin and comment for $INCLUDE per RFC 1035

Can we get this part committed to trunk? Thanks

comment:5 in reply to: ↑ 4 ; follow-up: Changed 9 years ago by zhanglikun

Replying to jreed:

Can we get this part committed to trunk? Thanks

is it urgent now? since tingting is on vocation now, I plan to continue loadzone tasks with her after 6.16(she will be back). Or else, I can reschedule my plan.

comment:6 in reply to: ↑ 5 Changed 9 years ago by jreed

  • Milestone set to 05. 3rd Incremental Release: Serious Secondary

Replying to zhanglikun:

is it urgent now?

No not urgent now. But I noticed because some of my zone files wouldn't load as-is. My concern is I think these fixes are included with other unrelated changes so maybe they aren't getting committed to trunk since the unrelated changes aren't getting reviewed. Maybe I will split them out myself.

(I set a milestone now.)

comment:7 Changed 9 years ago by shentingting

The code has been committed in r2340 in trunk, please check.

comment:8 Changed 9 years ago by jreed

  • Owner changed from shentingting to jreed
  • Status changed from reopened to reviewing

comment:9 Changed 9 years ago by shane

Did this go into the last release?

comment:10 Changed 9 years ago by zhanglikun

  • Resolution set to fixed
  • Status changed from reviewing to closed

Yes, it has been included in the latest release, so close this one.

Note: See TracTickets for help on using tickets.