Opened 8 years ago

Closed 7 years ago

#1939 closed defect (complete)

New cppcheck failures

Reported by: vorner Owned by:
Priority: medium Milestone: Sprint-DHCP-20130328
Component: libdhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

As always, I have a newer cppcheck than the build bots. They produce some more errors, some of which might be valid:

src/lib/dhcp/iface_mgr_linux.cc:133: check_fail: C-style pointer casting (style,cstyleCast)
src/lib/dhcp/iface_mgr_linux.cc:165: check_fail: C-style pointer casting (style,cstyleCast)
src/lib/dhcp/iface_mgr_linux.cc:322: check_fail: C-style pointer casting (style,cstyleCast)
src/lib/dhcp/iface_mgr_linux.cc:173: check_fail: Using size of pointer rta_tb instead of size of its data. (warning,pointerSize)
src/lib/dhcp/iface_mgr_linux.cc:188: check_fail: Using size of pointer rta_tb instead of size of its data. (warning,pointerSize)
src/lib/dhcp/iface_mgr_linux.cc:301: check_fail: Using size of pointer tb instead of size of its data. (warning,pointerSize)

As all are in the iface_mgr, I'm assigning it to the DHCP subproject.

Subtickets

Attachments (1)

cppcheck.txt (2.9 KB) - added by tmark 7 years ago.
Output of

Download all attachments as: .zip

Change History (4)

comment:1 Changed 8 years ago by shane

  • Defect Severity changed from N/A to Medium
  • Milestone changed from New Tasks to DHCP 2012

comment:2 Changed 7 years ago by stephen

  • Milestone changed from DHCP Outstanding Tasks to Sprint-DHCP-20130328

This may have been corrected in the meantime - the task is to run cppcheck and look at (and correct) whatever it throws up.

Changed 7 years ago by tmark

Output of

comment:3 Changed 7 years ago by tmark

  • Resolution set to complete
  • Status changed from new to closed

These errors appear to have been corrected. I installed cppcheck 1.58 on my Mac and the input is clean other than several "invalid branch" warnings, which are pre-existing. See the attached cppcheck output file.

Note: See TracTickets for help on using tickets.