Opened 8 years ago

Closed 7 years ago

#1909 closed defect (fixed)

"make check" fails if sqlite3 command line tool not installed

Reported by: shane Owned by: muks
Priority: medium Milestone: Sprint-20130514
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0.7 Internal?: no

Description

I ran "make check" and it failed on my system. An excerpt from the output:

/home/shane/tmp/bind10/src/bin/dbutil/tests/dbutil_test.sh: line 146: sqlite3: command not found
/home/shane/tmp/bind10/src/bin/dbutil/tests/dbutil_test.sh: line 146: sqlite3: command not found

I think we should either check for the sqlite3 command-line tool on configure or skip these tests if it is not present.

Subtickets

Change History (16)

comment:1 Changed 8 years ago by shane

There is also a ticket #1841, which recommends lettuce tests for this.

comment:2 Changed 8 years ago by shane

  • Milestone New Tasks deleted

comment:3 Changed 7 years ago by shane

  • Defect Severity changed from N/A to Low
  • Milestone set to Next-Sprint-Proposed
  • Priority changed from low to medium

This bit me again today (see ticket #2901).

comment:4 Changed 7 years ago by muks

  • Milestone changed from Next-Sprint-Proposed to Sprint-20130514

comment:5 Changed 7 years ago by muks

  • Owner changed from UnAssigned to muks
  • Status changed from new to assigned

Picking

comment:6 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

Up for review.

comment:7 follow-up: Changed 7 years ago by jinmei

  • Usual checkpoint: what about changelog?
  • Are we sure if that's the only dependency on sqlite3 executable?
  • I suggest moving the sqlite3 related part of configure.ac under m4macros/ at this opportunity. sqlite3 is (and will probably remain) a DNS specific dependency, so it will help make it easier to select features (DNS, DHCP, etc) if we separate uncommon settings into an external macro.

comment:8 Changed 7 years ago by jinmei

  • Owner changed from UnAssigned to muks

comment:9 in reply to: ↑ 7 ; follow-up: Changed 7 years ago by muks

  • Owner changed from muks to jinmei

Hi Jinmei

Replying to jinmei:

  • Usual checkpoint: what about changelog?

How does this look:

XXX.	[bug]		muks
	When the sqlite3 program is not available on the system (in
	PATH), we no longer attempt to run some tests which depend
	on it.
	(Trac #1909, git ...)
  • Are we sure if that's the only dependency on sqlite3 executable?

When the sqlite3 program was not available in the path, no other tests
failed for me.

  • I suggest moving the sqlite3 related part of configure.ac under m4macros/ at this opportunity. sqlite3 is (and will probably remain) a DNS specific dependency, so it will help make it easier to select features (DNS, DHCP, etc) if we separate uncommon settings into an external macro.

Done.

comment:10 in reply to: ↑ 9 ; follow-up: Changed 7 years ago by jinmei

Replying to muks:

  • Usual checkpoint: what about changelog?

How does this look:

XXX.	[bug]		muks
	When the sqlite3 program is not available on the system (in
	PATH), we no longer attempt to run some tests which depend
	on it.
	(Trac #1909, git ...)

Looks good.

  • I suggest moving the sqlite3 related part of configure.ac under m4macros/ at this opportunity. sqlite3 is (and will probably remain) a DNS specific dependency, so it will help make it easier to select features (DNS, DHCP, etc) if we separate uncommon settings into an external macro.

Done.

This generally looks good, but I have one question: do we need these?

AC_SUBST(SQLITE_CFLAGS)
AC_SUBST(SQLITE_LIBS)

These don't seem to be included in the original configure.ac.

comment:11 Changed 7 years ago by jinmei

  • Owner changed from jinmei to muks

comment:12 in reply to: ↑ 10 Changed 7 years ago by muks

  • Owner changed from muks to jinmei

Hi Jinmei

Replying to jinmei:

  • I suggest moving the sqlite3 related part of configure.ac under m4macros/ at this opportunity. sqlite3 is (and will probably remain) a DNS specific dependency, so it will help make it easier to select features (DNS, DHCP, etc) if we separate uncommon settings into an external macro.

Done.

This generally looks good, but I have one question: do we need these?

AC_SUBST(SQLITE_CFLAGS)
AC_SUBST(SQLITE_LIBS)

These don't seem to be included in the original configure.ac.

Hmm.. I did that out of habit. I guess PKG_CHECK_MODULES now
AC_SUBSTs them too. At some point in the past it didn't do that.
Removed now.

I've also EXTRA_DISTed those m4 files in m4macros/ in case someone
wants them to autoreconf the tree (some packagers do that when they
modify configure.ac).

distcheck passes on the branch.

comment:13 Changed 7 years ago by jinmei

looks okay, please merge.

comment:14 Changed 7 years ago by jinmei

  • Owner changed from jinmei to muks

comment:15 Changed 7 years ago by jinmei

  • Total Hours changed from 0 to 0.7

comment:16 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit f85b274b85b57a094d33ca06dfbe12ae67bb47df:

* 8d6493e [1909] EXTRA_DIST the m4 files
* f182b85 [1909] Remove redundant AC_SUBSTs
* fa72716 [1909] Move sqlite3 check to m4macros/ dir
* 63e9d90 [1909] Check for presence of sqlite3 program before using it

Also pushed ChangeLog entry:

* 46af17a [master] Add ChangeLog entry for #1909

Resolving as fixed. Thank you for the reviews Jinmei.

Note: See TracTickets for help on using tickets.