Opened 8 years ago

Closed 8 years ago

#1889 closed defect (fixed)

bind10 --config-file does not work

Reported by: jreed Owned by: jelte
Priority: medium Milestone: Sprint-20120515
Component: ~Boss of BIND (obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

bind10 --config-file does not work

I set it to my config and it was no used. I set it to some random file name and it was not used.

Subtickets

Change History (10)

comment:1 Changed 8 years ago by jreed

Also --clear-config does not work when used with --config-file that points to existing configuration.

comment:2 Changed 8 years ago by jelte

we use this extensively in some of our tests, so it can't completely not work...

was the argument a relative path? (i think i commented somewhere else already that if the path is relative and -p is not given, it doesn't work)

comment:3 Changed 8 years ago by jreed

Yes, I think it was a relative path and --data-path was not used. Maybe the bind10 should warn or fail in this case. No warning at all makes it confusing. Also the docs need to be more clear if this is desired.

comment:4 Changed 8 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120515

comment:5 Changed 8 years ago by jelte

  • Owner set to jelte
  • Status changed from new to assigned

comment:6 Changed 8 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from assigned to reviewing

Ready for review, added a helper function for determining the correct path and file (there are a few options, described in the docstring), separate function also makes it much easier to test :)

I also added a log info message that prints which file in ends up using

comment:7 Changed 8 years ago by haikuo

  • Owner changed from UnAssigned to haikuo
  • Status changed from reviewing to accepted

comment:8 follow-up: Changed 8 years ago by haikuo

  • Owner changed from haikuo to jelte
  • Status changed from accepted to reviewing

The codes you changed are OK, and no problem from my side. :)
But my question is that why we don't change the "--data-path" to "--config-path" in bind10 if this option is only about the configuration file path? Maybe it is relative easy understanding for users.

comment:9 in reply to: ↑ 8 Changed 8 years ago by jelte

Replying to haikuo:

The codes you changed are OK, and no problem from my side. :)
But my question is that why we don't change the "--data-path" to "--config-path" in bind10 if this option is only about the configuration file path? Maybe it is relative easy understanding for users.

Apparently the intention was to extended the --data-path argument later with non-configuration-related things. Now that --config-path is better maybe we don't even need the --data-path in the first place.

I think it warrants some discussion whether we keep it, change its name, or maybe even remove it. I'll post a message to -dev, but in the meantime, I think it may be out of scope for this ticket anyway.

So I intend to merge this, and depending on the discussion result, we can create a new ticket.

comment:10 Changed 8 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

merged, closing ticket,

Note: See TracTickets for help on using tickets.