Opened 8 years ago

Closed 8 years ago

#1885 closed defect (fixed)

b10-stats-httpd should not run by default

Reported by: jreed Owned by: muks
Priority: low Milestone: Sprint-20120515
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I don't think that bind10 should run the webserver for stats by default. The bob.spec currently has:

         "b10-stats-httpd": {
            "address": "StatsHttpd",
            "kind": "dispensable"
          },

You can get the same stats over cmdctl if desired. Running another webserver by default is not desired.

Subtickets

Change History (7)

comment:1 Changed 8 years ago by jinmei

hasn't this been already done in a more generic way?

comment:2 Changed 8 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120501

comment:3 Changed 8 years ago by muks

  • Owner set to muks
  • Status changed from new to assigned

Picking

comment:4 Changed 8 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

Up for review.

comment:5 Changed 8 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:6 Changed 8 years ago by jelte

  • Owner changed from jelte to muks

Looks good, and can be merged.

For the changelog, I prefer a third-person approach i.e. 'bind10 no longer starts b10-stats-httpd by default', but no strong opinion.

(oh, and btw, if you like to prevent conflicts, you can also propose the changelog here and commit it after merging, it tends to need a git commit has update anyway)

comment:7 Changed 8 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed to master:

* 5ffee90 [1885] Add ChangeLog entry
* 9594710 [1885] Fix lettuce tests, now that b10-stats-httpd isn't enabled by default
* 5c8bbd7 [1885] Turn off b10-stats-httpd in the default configuration

Resolving as fixed.

Note: See TracTickets for help on using tickets.