Opened 8 years ago

Closed 8 years ago

#1853 closed defect (fixed)

lettuce bindctl_commands test is fragile

Reported by: jinmei Owned by: muks
Priority: medium Milestone: Sprint-20120417
Component: statistics Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

It misunderstands this line as an indication that b10-stats is alive:

        StatsHttpd  Stats HTTP daemon

because it naively searches for the keyword "Stats".

Also, it should use a non default port for stats-httpd to reduce the
risk of conflict.

See http://git.bind10.isc.org/~tester/builder//BIND10-lettuce/20120327123553-MacOS/logs/lettuce.out

Subtickets

Change History (5)

comment:1 Changed 8 years ago by muks

  • Milestone changed from New Tasks to Sprint-20120417
  • Owner set to muks
  • Status changed from new to assigned

Moving to current sprint after asking on Jabber.

comment:2 Changed 8 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

This bug should be fixed by the following commit in the trac1818 branch:

* 86e48a5 [1853] Fix module_is_running() to check for component exactly

It's being addressed now as lettuce tests need to pass for #1818 to be completed.

Up for review.

comment:3 Changed 8 years ago by jelte

  • Owner changed from UnAssigned to muks

that fix looks good to me, I was thinking that perhaps it should be 'either start of line or preceded by whitespace' and 'either end of line or followed by whitespace'. But we can make it that if it turns out we actually need it :p

comment:4 Changed 8 years ago by muks

Maybe "last bindctl output should contain Stats exactly" should instead be changed to "last bindctl output should contain Stats component" considering the kind of test we do.

comment:5 Changed 8 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed to master:

* cf96b2a [1853] Fix module_is_running() to check for component exactly

Resolving bug as fixed.

Note: See TracTickets for help on using tickets.