Opened 8 years ago

Closed 8 years ago

#1852 closed defect (fixed)

stats httpd doesn't send 'stopping' if httpd port can't be opened

Reported by: jinmei Owned by: naokikambe
Priority: low Milestone: Sprint-20120501
Component: statistics Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Due to that, the bindctl_commands lettuce test fails when another
BIND 10 system (which doesn't allow the stats httpd to open the port -
IMO the lettuce should use a different port, but that's a separate
issue).

See http://git.bind10.isc.org/~tester/builder//BIND10-lettuce/20120327123553-MacOS/logs/lettuce.out

Subtickets

Change History (9)

comment:1 Changed 8 years ago by naokikambe

  • Milestone changed from New Tasks to Sprint-20120417
  • Owner set to naokikambe
  • Status changed from new to accepted

I'll pickup. The related ticket #1853 is already going on and this ticket isn't so difficult, I think.

comment:2 Changed 8 years ago by naokikambe

  • Owner changed from naokikambe to UnAssigned
  • Status changed from accepted to reviewing

trac1852 is ready for reviewing.

IMO I'm not sure the dying module should properly close the session even though a fatal error is caught. Also I think that lettuce test isn't originally intended for testing conflict of same HTTP ports.

Regards

comment:3 Changed 8 years ago by jinmei

If it's not urgent, I suggest this be reviewed in the next sprint,
so we don't have too many distractions that were originally not
planned.

At the moment I'll just reduce the priority.

comment:4 Changed 8 years ago by jinmei

  • Priority changed from medium to low

comment:5 Changed 8 years ago by naokikambe

  • Milestone changed from Sprint-20120417 to New Tasks

Maybe not urgent, Sorry. The milestone is back.

BTW the first log seems to be removed:
https://lists.isc.org/pipermail/bind10-tickets/2012-April/013624.html

comment:6 Changed 8 years ago by jreed

#1863 is the ticket for separate issue to use a different port,

comment:7 Changed 8 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120501

comment:8 follow-up: Changed 8 years ago by jelte

  • Owner changed from UnAssigned to naokikambe

IIRC there's been some discussion as to whether or not stats_httpd should shut down in the first place if it cannot bind to port (rather than doing nothing except listen for cc-session commands). But we can address that in a separate discussion and ticket, this change seems good, please merge.

comment:9 in reply to: ↑ 8 Changed 8 years ago by naokikambe

  • Resolution set to fixed
  • Status changed from reviewing to closed

Hello,

Sorry for the late reaction. Merging was done and the ticket is being closed. Thank you.

Replying to jelte:

IIRC there's been some discussion as to whether or not stats_httpd should shut down in the first place if it cannot bind to port (rather than doing nothing except listen for cc-session commands).

Or maybe the new msgq might do instead.

Note: See TracTickets for help on using tickets.