Opened 8 years ago

Closed 8 years ago

#1825 closed enhancement (fixed)

Remove uses of LOG4CPLUS_OPEN_MODE_TYPE and LOG4CPLUS_FSTREAM_NAMESPACE.

Reported by: wilx Owned by: muks
Priority: medium Milestone: Sprint-20120403
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I am attaching a patch that removes uses of LOG4CPLUS_OPEN_MODE_TYPE and LOG4CPLUS_FSTREAM_NAMESPACE that are provided by log4cplus library in version 1.0.4. The macros are removed in upcoming 1.1.0 release of the library. At this time and age they are unnecessary as all reasonable C++ compilers have reasonably standard C++ library.

Subtickets

Attachments (1)

logger_manager_impl.cc.diff (608 bytes) - added by wilx 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by wilx

comment:1 Changed 8 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120403

Cool, thanks!

Adding this to sprint so we can have a look and merge it.

comment:2 Changed 8 years ago by jelte

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:3 Changed 8 years ago by muks

  • Owner changed from UnAssigned to muks

Picking

comment:4 Changed 8 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

I confirm that appending still works as before. The patch is fine.

Pushed into master, along with another patch:

* 43b5b82 [master] Change log file maxsize setting in the BIND 10 guide example
* c5a9c69 bug #1825: Don't use log4cplus macros which are going to be obsolete soon

Resolving as fixed. Thank you for submitting the patch. :)

Note: See TracTickets for help on using tickets.