Opened 8 years ago

Closed 8 years ago

#1823 closed task (fixed)

remove ASIO_DISABLE_KQUEUE hack

Reported by: jinmei Owned by: jreed
Priority: medium Milestone: Sprint-20120417
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 1 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

We can now probably remove this kludge from configure.ac:

AC_CHECK_FUNC(kqueue, ac_cv_have_kqueue=yes, ac_cv_have_kqueue=no)
if test "X$ac_cv_have_kqueue" = "Xyes"; then
	AC_MSG_CHECKING([whether kqueue EV_SET compiles in C++])
	AC_TRY_COMPILE([
#include <sys/types.h>
#include <sys/param.h>
#include <sys/event.h>],
[char* udata;
struct kevent kevent;
EV_SET(&kevent, 0, 0, 0, 0, 0, udata);],
	[AC_MSG_RESULT(yes)],
	[AC_MSG_RESULT([no, disable kqueue for ASIO])
	 CPPFLAGS="$CPPFLAGS -DASIO_DISABLE_KQUEUE=1"
	])
fi

This was a workaround for NetBSD, but apparently a more recent version
() of ASIO has its own workaround:

#if defined(__NetBSD__)
# define ASIO_KQUEUE_EV_SET(ev, ident, filt, flags, fflags, data, udata) \
    EV_SET(ev, ident, filt, flags, fflags, \
      data, reinterpret_cast<intptr_t>(udata))

So I guess we should be able to remove this hack.

Subtickets

Change History (7)

comment:1 follow-up: Changed 8 years ago by vorner

Do we use the newer version of ASIO already, or should it be imported first?

comment:2 in reply to: ↑ 1 Changed 8 years ago by jinmei

Replying to vorner:

Do we use the newer version of ASIO already, or should it be imported first?

We use the newer version of it already.

comment:3 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120417

comment:4 follow-up: Changed 8 years ago by jreed

I verified this on one of my NetBSD systems. Want me to just commit configure.ac change to master? No changelog entry needed.

comment:5 in reply to: ↑ 4 Changed 8 years ago by jinmei

Replying to jreed:

I verified this on one of my NetBSD systems. Want me to just commit configure.ac change to master?

Yes, please.

comment:6 Changed 8 years ago by jinmei

  • Owner changed from UnAssigned to jreed
  • Status changed from new to assigned

comment:7 Changed 8 years ago by jreed

  • Resolution set to fixed
  • Status changed from assigned to closed

commit 81300648c7274effe356e4ba421cdf3cdab8d316

Note: See TracTickets for help on using tickets.