Opened 8 years ago

Closed 6 years ago

#1796 closed task (fixed)

auth:query.cc:A_AND_AAAA should go to Query class

Reported by: jinmei Owned by: muks
Priority: medium Milestone: bind10-1.2-release-freeze
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: auth performance
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by jinmei)

Now the Query class is reused, it would be even more efficient
to build the vector in its constructor.

This is a small cleanup and should be very easy.

Subtickets

Change History (7)

comment:1 Changed 8 years ago by jinmei

  • Description modified (diff)

comment:2 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 2

comment:3 Changed 6 years ago by muks

This improvement will be almost negligible as after the first time the vector is created, only the empty() test (a minor constant time check) is extra overhead. I don't think it's necessary to do this as the current separation using an anonymous function (with static vector) is superior.

However, because this ticket has been estimated and all, I guess others have looked at it and think it's necessary.

comment:4 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Owner set to UnAssigned
  • Status changed from new to reviewing

Up for review.

comment:5 Changed 6 years ago by muks

No ChangeLog is unnecessary.

comment:6 Changed 6 years ago by shane

  • Owner changed from UnAssigned to muks

This ticket seems correct, although I agree with your assessment.

I guess the point is that since a Query instance is re-used the cost of checking is higher than the cost of constructing, since the check is done every time we build an additional section.

I do agree with you that the gain is minimal if even measurable, but I suppose we may as well go ahead and merge this change, since it is so small.

comment:7 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 99ca75676abbf8360b807a1c36143d87f393c89a:

* fb50e3b [1796] Move A_AND_AAAA to the Query class

Resolved as fixed. Thank you for the review Shane.

Note: See TracTickets for help on using tickets.