Opened 8 years ago

Closed 8 years ago

#1792 closed task (complete)

update b10-auth config handler to support in-memory/sqlite3

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: Sprint-20120417
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: xfr for in-memory
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 6.83 Internal?: no

Description (last modified by jinmei)

This is a subtask of #1787.

We extend auth_config.cc:MemoryDatasourceConfig so that if the
"filetype" is "sqlite3" (see #1788), it creates a ZoneIterator for
the underlying SQLite3 data source and uses the iterator version of
InMemoryZoneFinder::load() (see #1791) to load the zone.

Note that this means the config handler needs to instantiate a
DataSourceClient for the corresponding SQLite3 data source.
Right now I'm not sure how easy/difficult it is.
See also #1793. There should be some kind of coordination.

This task depends on #1788 and #1791.

Subtickets

Change History (11)

comment:1 Changed 8 years ago by jinmei

  • Description modified (diff)

comment:2 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 5

comment:3 Changed 8 years ago by jelte

  • Milestone changed from Year 3 Task Backlog to Sprint-20120417

comment:4 follow-up: Changed 8 years ago by jinmei

  • Owner set to jinmei
  • Status changed from new to accepted

comment:5 in reply to: ↑ 4 Changed 8 years ago by jinmei

trac1792 is ready for review.

It depends on #1791, which is still in review, but my understanding of
the discussions for #1791 is that the review results won't affect what
we should do for this ticket.

the first commit is to merge #1791, and should be ignored for review.

The next couple of changes up to aaf4fb3 are trivial (unrelated)
cleanups.

The next two up to 501c5f2 are a set up for testing the main feature
of the branch, and 9b060a7 is the main code and the test.

I also added a simple lettuce feature to check the basic behavior at
the higher level.

I don't yet plan to add a changelog entry. We can add a unified entry
when #1793 is done.

comment:6 Changed 8 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from accepted to reviewing

comment:7 Changed 8 years ago by kevin_tes

  • Owner changed from UnAssigned to kevin_tes

comment:8 follow-up: Changed 8 years ago by kevin_tes

  • Owner changed from kevin_tes to jinmei

Looks good to me,please merge.

comment:9 Changed 8 years ago by muks

jinmei: Now that #1818 is merged into master, auth, xfr*, etc. are off by default. You may have to rewrite the lettuce feature and config based on some other current feature+config files.

comment:10 in reply to: ↑ 8 Changed 8 years ago by jinmei

Replying to kevin_tes:

Looks good to me,please merge.

Thanks, merge done, closing.

(I also updated the lettuce test configuration to specify the necessary components
explicitly).

comment:11 Changed 8 years ago by jinmei

  • Resolution set to complete
  • Status changed from reviewing to closed
  • Total Hours changed from 0 to 6.83
Note: See TracTickets for help on using tickets.