Opened 10 years ago

Closed 10 years ago

#179 closed task (fixed)

more test for xfrin

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: 04. 2nd Incremental Release: Early Adopters
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Subtickets

Change History (5)

comment:1 Changed 10 years ago by jinmei

  • Owner set to UnAssigned
  • Status changed from new to reviewing

branches/trac179 is ready for review.

In this patch I've focused on widen code-wise coverage, and tried to minimize changes to the test target code (xfrin.py.in).

Right now it covers 84% of the code:
http://bind10.isc.org/~jinmei/xfrin-coverage/python-coverage/_Users_jinmei_src_isc_bind10_trunk_src_bin_xfrin_xfrin.html

and as you can see it actually covers most substantial part of the code.

I've already identified some bugs (noted in the TODO file) and am quite sure that there are some more espeially around corner cases, but I think it makes sense to get the current test set reviewed to keep the reviewer's load minimal.

comment:2 Changed 10 years ago by shane

  • Owner changed from UnAssigned to shane
  • Status changed from reviewing to accepted

comment:3 Changed 10 years ago by shane

  • Owner changed from shane to jelte
  • Status changed from accepted to reviewing

comment:4 follow-up: Changed 10 years ago by jelte

  • Owner changed from jelte to jinmei

Looking good. I want this in before i finalize the new wrappers :)

comment:5 in reply to: ↑ 4 Changed 10 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to jelte:

Looking good. I want this in before i finalize the new wrappers :)

Thanks, committed to trunk (r1875). Closing.

Note: See TracTickets for help on using tickets.