Opened 8 years ago

Closed 8 years ago

#1746 closed defect (fixed)

cleanup: remove "temporary" SQLite3Accessor::getRecordDiff()

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: Sprint-20120417
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 1.42 Internal?: no

Description

As commented in the header file:

    // A short term method for tests until we implement more complete
    // API to retrieve diffs (#1330).  It returns all records of the diffs
...
    // in favor of brevity.  Once #1330 is completed, this method must be
    // removed, and the tests using this method must be rewritten using the
    // official API.

#1330 was completed much before but apparently we forgot to do this

cleanup. We should do it now.

Subtickets

Change History (8)

comment:1 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 3

comment:2 Changed 8 years ago by jinmei

  • Milestone changed from Year 3 Task Backlog to Next-Sprint-Proposed

comment:3 Changed 8 years ago by jinmei

trac1746 is ready for review. (I'll move it to the current sprint).

it should be a straightforward cleanup.

comment:4 Changed 8 years ago by jinmei

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120403
  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:5 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:6 follow-up: Changed 8 years ago by vorner

  • Owner changed from vorner to jinmei
  • Total Hours changed from 0 to 0.27

comment:7 in reply to: ↑ 6 Changed 8 years ago by jinmei

Thanks for review.

As confirmed on jabber, I've merged the branch. Closing ticket.

comment:8 Changed 8 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Total Hours changed from 0.27 to 1.42
Note: See TracTickets for help on using tickets.