Opened 8 years ago

Closed 8 years ago

#1741 closed defect (fixed)

Duplicate RESOLVER_SHUTDOWN message

Reported by: stephen Owned by: jelte
Priority: low Milestone: Sprint-20120320
Component: resolver Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The RESOLVER_SHUTDOWN message is duplicated in the file resolver_messages.mes. It is also used twice in the code, once in a LOG_INFO call and once in a LOG_DEBUG call.

Subtickets

Change History (9)

comment:1 Changed 8 years ago by jreed

#1055 should be a priority to check for messages used twice in the code.

comment:2 Changed 8 years ago by jelte

This particular error would've also been caught by the changes made in #1093 (but that never got merged because it is an incomplete solution i think)

comment:3 Changed 8 years ago by stephen

  • Milestone changed from New Tasks to Next-Sprint-Proposed

comment:4 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 2

comment:5 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120320

comment:6 Changed 8 years ago by jelte

  • Owner set to UnAssigned
  • Status changed from new to reviewing

taking the path of least resistance, I've changed the debug message to RESOLVER_SHUTDOWN_RECEIVED (I do think, as a debug message, it has its use;

The fix is trivial; but I did merge #1039 into this branch first, to see how well it works, so you can see it fail at 736fb87e53b0d57241c4e414ed5de2f3eacc6e6e. Second commit changes message id (and log message itself)

comment:7 Changed 8 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:8 Changed 8 years ago by stephen

  • Owner changed from stephen to jelte

Looks OK, please merge.

Incidentally, you may want to run the message file through tools/reorder_message_file.py to get the message IDs in alphabetical order before you commit - it should make errors like this less likely.

comment:9 Changed 8 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

Thanks, merged, closing ticket.

Note: See TracTickets for help on using tickets.