Opened 8 years ago

Closed 8 years ago

#1735 closed defect (fixed)

ddns_socket file left in build directory

Reported by: jreed Owned by: muks
Priority: low Milestone: Sprint-20120612
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: DDNS
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

After a make check and then make distclean I have:

srwxr-xr-x 1 reed reed 0 Feb 29 15:15 ddns_socket

Subtickets

Change History (11)

comment:1 Changed 8 years ago by shane

  • Milestone New Tasks deleted

comment:2 Changed 8 years ago by jinmei

  • Feature Depending on Ticket set to DDNS
  • Milestone set to Next-Sprint-Proposed

comment:3 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120612

comment:4 Changed 8 years ago by muks

  • Owner set to muks
  • Status changed from new to assigned

Picking

comment:5 Changed 8 years ago by muks

  • Owner changed from muks to UnAssigned

Up for review.

comment:6 Changed 8 years ago by muks

  • Status changed from assigned to reviewing

comment:7 Changed 8 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:8 follow-up: Changed 8 years ago by jelte

  • Owner changed from jelte to muks

The method you added duplicates an existing one, which should actually be called already (clear_socket()).

Some of the unit tests is mucking with it, and they appear to put it back, but only after it would have been called; I suspect that we should make them either real proxies (easy way would be to add self.__orig_clear() to __clear_socket() in ddns_test.py around line 380. An alternative would be to explicitly call it in the tearDown() there, after it is put back, but I think i personally prefer the former.

comment:9 in reply to: ↑ 8 Changed 8 years ago by muks

  • Owner changed from muks to jelte

Replying to jelte:

The method you added duplicates an existing one, which should actually be called already (clear_socket()).

Aiieeeee... aiieeeeeeee!

Some of the unit tests is mucking with it, and they appear to put it back, but only after it would have been called; I suspect that we should make them either real proxies (easy way would be to add self.__orig_clear() to __clear_socket() in ddns_test.py around line 380. An alternative would be to explicitly call it in the tearDown() there, after it is put back, but I think i personally prefer the former.

Yes the former approach is good. I've made a fresh branch (trac1735_2) and verified that the stale socket file is removed.

comment:10 Changed 8 years ago by jelte

  • Owner changed from jelte to muks

That looks ok :) Pease go ahead and merge

comment:11 Changed 8 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master:

* 18aa535 [1735] Get rid of the socket file when ddns.clear_socket() is overridden

Resolving as fixed. Thank you for the review Jelte.

Note: See TracTickets for help on using tickets.