Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1722 closed defect (fixed)

RR reader EOL whitespace

Reported by: jelte Owned by: jelte
Priority: medium Milestone: Sprint-20120306
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 1 Add Hours to Ticket: 2
Total Hours: 0.22 Internal?: no


End-of-line comment parsing was fixed in the workaround in #1667, but the reader also fails on EOL whitespace (which some signers print for some types) for most types (it kind of depends on the last rdata type).


Change History (5)

comment:1 Changed 8 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120306
  • Owner set to UnAssigned
  • Status changed from new to reviewing

Ok ready for review

comment:2 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:3 Changed 8 years ago by vorner

  • Owner changed from vorner to jelte


It looks OK, except that all the added tests has this comment at the beginning, which is not true at any of them. I guess it's a copy-paste of a different test:

TEST_F(MasterLoadTest, loadRRWithEOLWhitespaceTab) {
    // Similar to the previous one, but there's no space before comments.
    // It should still work.

After fixing them, I think this can be merged (but maybe it could use little bit of history rewriting to avoid the inclusion and removal of the wrong commit before merge ‒ I could do that, if it is a problem).

comment:4 Changed 8 years ago by jelte

  • Add Hours to Ticket changed from 0 to 2
  • Resolution set to fixed
  • Status changed from reviewing to closed

ok, thanks! merged, closing ticket

comment:5 Changed 8 years ago by vorner

  • Total Hours changed from 0 to 0.22
Note: See TracTickets for help on using tickets.