Opened 8 years ago

Closed 8 years ago

#1680 closed task (fixed)

Remove --enable-boost-threads from configure

Reported by: vorner Owned by: haikuo
Priority: medium Milestone: Sprint-20120403
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The flag has no benefit for user (as it replaces our dummy locks in NSAS library with real ones, but we don't use threads yet, so we don't need locks), only slows things down. Furthermore, it seems the code doesn't work with the locks anymore (see #1672), so I think we should comment the flag out in configure until it'll have a real reason to exist, to prevent users from enabling it by accident.

Subtickets

Change History (15)

comment:1 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 3

comment:2 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120306

comment:3 Changed 8 years ago by haikuo

  • Owner changed from UnAssigned to haikuo
  • Status changed from new to accepted

comment:4 Changed 8 years ago by haikuo

  • Owner changed from haikuo to UnAssigned
  • Status changed from accepted to reviewing

modified configure.ac src/lib/cache/tests/makefile.am and src/lib/nsas/tests/Makefile.am.

comment:5 Changed 8 years ago by muks

  • Owner changed from UnAssigned to haikuo

Patch looks good. Now it uses the dummy lock code always.

comment:6 Changed 8 years ago by jinmei

Just checking: why is this ticket still open?

It seems we can simply merge the branch and close the ticket now.

comment:7 Changed 8 years ago by haikuo

according muks's suggestion, I remove the codes in locks.h file and that codes should be never be compiled if remove --enable-boost-threads.

comment:8 Changed 8 years ago by haikuo

  • Resolution set to fixed
  • Status changed from reviewing to closed

the ticket has been merged into master,and fixed it.

comment:9 Changed 8 years ago by jreed

  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening this ticket due to missing changelog entry. If not desired, please document here in ticket comments. The reason I bring this up is a user reported related issue #1672.

comment:10 Changed 8 years ago by haikuo

  • Owner changed from haikuo to jreed
  • Status changed from reopened to reviewing

the documentation is followed:

remove " --enable-boost-threads" switch in configure command. this threads lock mechanism is useless for bind10 and cause performance hits.

comment:11 Changed 8 years ago by muks

  • Milestone changed from Sprint-20120306 to Sprint-20120320

Moving to current milestone. Please resolve this ticket if it's done.

comment:12 Changed 8 years ago by haikuo

  • Resolution set to fixed
  • Status changed from reviewing to closed

the changelog has been updated for this ticket.
and it could be fixed now.

comment:13 Changed 8 years ago by muks

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:14 Changed 8 years ago by muks

  • Owner changed from jreed to haikuo
  • Status changed from reopened to assigned

comment:15 Changed 8 years ago by muks

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.