Opened 8 years ago

Closed 6 years ago

#1666 closed defect (worksforme)

in-memory iterator should include NSEC3 RRs

Reported by: jinmei Owned by: muks
Priority: medium Milestone: bind10-1.2-release-freeze
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I've not actually tested it, but I believe NSEC3 RRs are excluded
from the iterator. We should fix it.

Also not tested, but it'd be good to check if RRSIGs (for NSEC3 and
for non NSEC3) are included in iterator output.

Subtickets

Change History (5)

comment:1 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 5

comment:2 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Owner set to UnAssigned
  • Status changed from new to reviewing

NSEC3 RRs do seem to be included, and their RRSIGs would be separated too if called with separate_rrs=true.

I have reviewed this code carefully and it seems to be correctly done. Please can another pair of eyes review the MemoryIterator pedantically?

comment:3 Changed 6 years ago by muks

After this, #2271 can be resolved.

comment:4 Changed 6 years ago by pselkirk

  • Owner changed from UnAssigned to muks

I'm not sure it qualifies as a "pedantic" review, but I've had a careful read-through of MemoryIterator and related classes, and it seems to work as you say. I'd say we can close this ticket as already fixed.

comment:5 Changed 6 years ago by muks

  • Resolution set to worksforme
  • Status changed from reviewing to closed

Resolving as worksforme. Thank you for the review Paul.

Note: See TracTickets for help on using tickets.