Opened 8 years ago

Closed 8 years ago

#1644 closed defect (fixed)

system include header ordering needs

Reported by: jreed Owned by: jreed
Priority: medium Milestone: Sprint-20120320
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Some systems header's don't include their needed headers. So you can get errors like:

/usr/include/netinet/in.h:141: error: 'in_addr_t' does not name a type

...

/usr/include/netinet6/in6.h:118: error: 'u_int8_t' does not name a type

...

../../../ext/asio/asio/detail/impl/socket_ops.ipp:93: error: 'msg_namelen' is not a member of 'msghdr'

...

../../../ext/asio/asio/ip/impl/address_v6.ipp:193: error: 'const union in6_addr::<anonymous>' has no member named '__u6_addr8'


(maybe thousands of errors)

The fixes are trivial but I am making a branch to test first on various systems.

Subtickets

Change History (10)

comment:1 Changed 8 years ago by jreed

commit 78c0ce22b39230347bc652f7903aac57d2b4c577

comment:2 Changed 8 years ago by shane

  • Milestone changed from New Tasks to Year 3 Task Backlog

comment:3 Changed 8 years ago by jreed

  • Milestone changed from Year 3 Task Backlog to Next-Sprint-Proposed

comment:4 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120306

comment:5 Changed 8 years ago by jreed

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:6 Changed 8 years ago by jinmei

The changes do not seem to be incorrect, but could you briefly explain
why we need them? For someone whose system doesn't have a build
issue it's not clear.

I'd also note that we should check if it compiles even after our new
policy of header file ordering: BIND 10 internal headers first,
external libraries headers second, semi-standard (boost) headers
third, then standard system headers. Maybe we should even do that
change to the relevant files within this ticket.

comment:7 Changed 8 years ago by jinmei

  • Owner changed from UnAssigned to jreed

comment:8 Changed 8 years ago by jreed

I will need to retest after the weekend. But I think the explanations are in my git commit messages.

comment:9 Changed 8 years ago by jreed

I plan to merge master into my branch, test once more and then have build farm use that branch and then commit/push to master. That is per quick discussion on phone meeting on March 6. I will do this tomorrow (march 15).

comment:10 Changed 8 years ago by jreed

  • Resolution set to fixed
  • Status changed from reviewing to closed

Some was done independently. I merged in my changes and fixed some conflicts and merged to master and now closing this ticket.

Note: See TracTickets for help on using tickets.