Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1639 closed defect (fixed)

perfdhcp.c uses pselect

Reported by: jreed Owned by: muks
Priority: low Milestone: Sprint-20120403
Component: perfdhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Maybe perfdhcp.c should use select or poll?

OpenBSD does not have pselect(2).

For now maybe disable perfdhcp on OpenBSD.

Subtickets

Change History (11)

comment:1 Changed 8 years ago by shane

  • Milestone changed from New Tasks to DHCP 2012

comment:2 Changed 8 years ago by muks

  • Milestone changed from DHCP 2012 to Sprint-20120320
  • Owner set to muks
  • Status changed from new to assigned

Picking bug and setting to current BIND 10 milestone.

Done after discussion with Shane on Jabber. We want to fix all the OpenBSD issues.

comment:3 Changed 8 years ago by muks

Patch with wrapper around select() for OpenBSD is in the trac1639 branch. It still needs a bit of testing before review.

comment:4 Changed 8 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

Up for review.

comment:5 Changed 8 years ago by jinmei

  • Owner changed from UnAssigned to jinmei

comment:6 follow-up: Changed 8 years ago by jinmei

I made a couple of minor editorial fixes and changed the branch
directly.

Another minor comment: maybe we'll use pselect for other places than
perfdhcp in future, so I'd be a bit more generic here:

# Check for pselect() for use in perfdhcp
AC_CHECK_FUNCS([pselect])

Maybe something like "Check for pselect() in some of the code"? Not
sure if this makes more sense though...I'd leave it to you.

I also think we need a changelog for this.

Other than these, the branch looks okay.

comment:7 Changed 8 years ago by jinmei

  • Owner changed from jinmei to muks

comment:8 in reply to: ↑ 6 ; follow-up: Changed 8 years ago by muks

Replying to jinmei:

Another minor comment: maybe we'll use pselect for other places than
perfdhcp in future, so I'd be a bit more generic here:

# Check for pselect() for use in perfdhcp
AC_CHECK_FUNCS([pselect])

Maybe something like "Check for pselect() in some of the code"? Not
sure if this makes more sense though...I'd leave it to you.

I've changed it to the following:

-# Check for pselect() for use in perfdhcp
+# Check for functions that are not available on all platforms
 AC_CHECK_FUNCS([pselect])

comment:9 Changed 8 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed to master:

* 766e745 bug #1639: Change comment in configure.ac
* 228fe4a [1639] some minor editorial fixes: () for return, indentation consistency
* d576a15 bug #1639: Add comment to endif
* 6ea0b1d bug #1639: Implement a pselect() wrapper around select() for OpenBSD

Resolving bug as fixed.

comment:10 in reply to: ↑ 8 ; follow-up: Changed 8 years ago by jinmei

Replying to muks:

Checking: what about changelog? In this particular case, if your
decision was not to add it, I'm okay with that. But in generally
we expect all issues raised in review be addressed (even if the
resolution is "reject it") before merge and close.

comment:11 in reply to: ↑ 10 Changed 8 years ago by muks

Replying to jinmei:

Replying to muks:

Checking: what about changelog? In this particular case, if your
decision was not to add it, I'm okay with that. But in generally
we expect all issues raised in review be addressed (even if the
resolution is "reject it") before merge and close.

I missed it! Fixed now.

+406.   [bug]           muks
+       On platforms such as OpenBSD where pselect() is not available,
+       make a wrapper around select() in perfdhcp.
+       (Trac #1639, git 6ea0b1d62e7b8b6596209291aa6c8b34b8e73191)
+
Note: See TracTickets for help on using tickets.