Opened 8 years ago

Closed 3 years ago

#1609 closed task (complete)

Review object breakdown of DHCP code

Reported by: stephen Owned by: tomek
Priority: low Milestone: Kea1.2
Component: dhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0.5
Total Hours: 0.5 Internal?: no

Description

Review the object structure of the BIND 10 DHCP code to date and make recommendations about any refactoring needed.

Subtickets

Change History (13)

comment:1 Changed 8 years ago by stephen

  • Milestone changed from DHCP 2012 to Sprint-DHCP-20120220

comment:2 Changed 8 years ago by stephen

  • Milestone changed from Sprint-DHCP-20120514 to DHCP 2012

comment:3 Changed 8 years ago by stephen

  • Milestone changed from DHCP 2012 to Sprint-DHCP-20120528

comment:4 Changed 7 years ago by shane

  • Owner set to shane
  • Status changed from new to accepted

comment:5 Changed 7 years ago by stephen

  • Milestone changed from Sprint-DHCP-20121213 to DHCP Outstanding Tasks
  • Owner changed from shane to UnAssigned
  • Status changed from accepted to assigned

comment:6 Changed 7 years ago by stephen

  • Milestone changed from DHCP Outstanding Tasks to Sprint-DHCP-20130328

comment:7 Changed 7 years ago by stephen

  • Milestone changed from Sprint-DHCP-20130509 to DHCP Outstanding Tasks

comment:8 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:9 Changed 3 years ago by tomek

One obvious refactoring area are parsers. We need to rewrite them in a sane way.

comment:10 Changed 3 years ago by tomek

  • Milestone changed from Outstanding Tasks to Kea1.2

comment:11 Changed 3 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:12 Changed 3 years ago by tomek

  • Priority changed from medium to low

comment:13 Changed 3 years ago by tomek

  • Add Hours to Ticket changed from 0 to 0.5
  • Resolution set to complete
  • Status changed from assigned to closed
  • Total Hours changed from 0 to 0.5

The Kea team has discussed the object breakdown of the DHCP code and we came up with several conclusions.

  1. the parsers structure is a mess. For each entry in a config file we create a separate class instance. If you have 1000 host reservations, each with 2 parameters, we create 2000 instances of parsers. The parser refactoring is a major part of the 1.2 release. The tickets specific to this refactor are listed on this page: SimpleParser.
  1. some of the classes used in D2 are really generic and should be moved to a separate library. #3175 and #5074 took care of this.

We did discuss this matter on jabber and the conclusion was that the major refactors needed are already in progress. The general review is simply too broad to be practical and actionable. While there are certainly object breakdowns possible that are different than what we currently have in the code, those will be assessed and implemented on as needed basis. As such, they don't require any dedicated ticket. Therefore I decided to resolve this ticket.

Note: See TracTickets for help on using tickets.