Opened 8 years ago

Closed 8 years ago

#1578 closed task (complete)

Update in memory ZoneFinder::find() for negative cases of NSEC3-signed zones

Reported by: jinmei Owned by: jinmei
Priority: high Milestone: Sprint-20120207
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: NSEC3
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 4.60 Internal?: no

Description (last modified by jinmei)

(updated based on #1431 discussion)

The find() method will be expected to provide some useful information
with negative results to help the upper layer collect necessary NSEC3
RRs. Specifically:

  • For wildcard involved results, set the RESULT_WILDCARD flag
  • in case of NXDOMAIN and NXRRSET, if the zone is signed with NSEC3 set the RESULT_NSEC3_SIGNED flag

This task implements these in in-memory data source.

It depends on #1431 (for the flag definitions), and possibly on #1574
to know whether the zone is signed with NSEC3 (but these could be done
in parallel with adjusting interfaces on merge).

Subtickets

Change History (11)

comment:1 Changed 8 years ago by jinmei

  • Feature Depending on Ticket set to NSEC3

comment:2 Changed 8 years ago by jinmei

  • Description modified (diff)

comment:3 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 5

comment:4 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120207
  • Priority changed from major to critical

comment:5 Changed 8 years ago by jinmei

  • Owner set to jinmei
  • Status changed from new to accepted

comment:6 Changed 8 years ago by jinmei

trac1578 is ready for review.

It's based on the 1574b branch, and the first commit is to merge it
(should be ignored for review).

The main changes should be straightforward. Test updates are
relatively big, but it basically just confirms the expected result
flags are set for various cases.

There are some unrelated cleanups in the branch. They are noted so
in the commit logs.

I don't plan to add a changelog entry for this update.

comment:7 Changed 8 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from accepted to reviewing

comment:8 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:9 follow-up: Changed 8 years ago by vorner

  • Owner changed from vorner to jinmei

Hello

Do I look correctly the only change to the code was to add the flags in the createFindResult? (Just confirming I didn't overlook anything)

Anyway, I found only this in the comment:

// simply ignore these when then didn't request DNSSEC related results.

It should be they, not then, I think.

If I didn't overlook anything, I think it can be merged.

Thank you

comment:10 in reply to: ↑ 9 Changed 8 years ago by jinmei

Replying to vorner:

Do I look correctly the only change to the code was to add the flags in the createFindResult? (Just confirming I didn't overlook anything)

Yes, that's correct.

Anyway, I found only this in the comment:

// simply ignore these when then didn't request DNSSEC related results.

It should be they, not then, I think.

Good catch, I've fixed in the branch.

If I didn't overlook anything, I think it can be merged.

Okay, thanks, merge done, closing.

comment:11 Changed 8 years ago by jinmei

  • Resolution set to complete
  • Status changed from reviewing to closed
  • Total Hours changed from 0 to 4.60
Note: See TracTickets for help on using tickets.