Opened 8 years ago

Closed 8 years ago

#1571 closed task (fixed)

DS query handling in in-memory data source

Reported by: jinmei Owned by: jinmei
Priority: high Milestone: Sprint-20120207
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0.5 Internal?: no

Description

DS query requires special handling (see also #1570). We need to
update InMemoryZoneFinder::find() so that if the query type is
DS and the qname is not the zone origin it will handle the case as if
it were above the zone cut (i.e., as authoritative lookup).

Subtickets

Change History (9)

comment:1 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 5

comment:2 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120207
  • Priority changed from major to critical

comment:3 Changed 8 years ago by jinmei

  • Owner set to jinmei
  • Status changed from new to accepted

comment:4 Changed 8 years ago by jinmei

trac1571 is ready for review.

This is quite simple, and basically follows what BIND 9 does.
In fact, BIND 9 generalizes it by introducing the notion of "at
parent" type of RRs, but I don't see the need for generalization
(DS is really special anyway, and in the BIND 9 implementation it's
actually the only "at parent" type), so I was just explicit in this
code.

BTW: I suspect we need to do the same thing for the database finder.

This one could also be considered a bug fix, so this is the proposed
changelog entry:

365.?	[bug]		jinmei
	libdatasrc: in-memory datasource incorrectly returned delegation
	for DS lookups.
	(Trac #1571, git TBD)

comment:5 Changed 8 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from accepted to reviewing

comment:6 Changed 8 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:7 follow-up: Changed 8 years ago by jelte

  • Owner changed from jelte to jinmei

Looks good, please merge

comment:8 in reply to: ↑ 7 Changed 8 years ago by jinmei

Replying to jelte:

Looks good, please merge

Thanks for the quick review. Merge done, closing.

comment:9 Changed 8 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Total Hours changed from 0 to 0.5
Note: See TracTickets for help on using tickets.