Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1567 closed defect (fixed)

missing include/linux/if_link.h

Reported by: jreed Owned by: jelte
Priority: medium Milestone:
Component: dhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The CentOS 5.3 system with Linux 2.6.18-128.7.1.el5 fails with:

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/lib -I../../../src/lib -I/home/jreed/pkg/include/ -I/home/jreed/pkg/include -DOS_LINUX -I../../../ext/asio -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wall -Wextra -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -fPIC -g -O2 -MT libdhcp___la-iface_mgr_linux.lo -MD -MP -MF .deps/libdhcp___la-iface_mgr_linux.Tpo -c iface_mgr_linux.cc  -fPIC -DPIC -o .libs/libdhcp___la-iface_mgr_linux.o
iface_mgr_linux.cc:24:27: error: linux/if_link.h: No such file or directory
make[5]: *** [libdhcp___la-iface_mgr_linux.lo] Error 1
make[5]: Leaving directory `/home/jreed/builder/work/BIND10/20120112081107-CentOS5-x86_64-GCC/build/src/lib/dhcp'

This version of Linux does not provide the header:

$ rpm -ql kernel-headers-2.6.18-128.7.1.el5 | grep linux/if_l
/usr/include/linux/if_ltalk.h

Subtickets

Change History (6)

comment:1 Changed 8 years ago by jelte

  • Owner set to jelte
  • Status changed from new to assigned

comment:2 Changed 8 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from assigned to reviewing

Looks like it isn't even needed; on that CentOS system, the symbols that are defined by if_link.h are directly defined by rtnetlink.h (which is the next include), on systems that do have if_link.h, it is included by rtnetlink.h.

One line patch committed to branches/trac1567

comment:3 Changed 8 years ago by jinmei

Not actually tested, but the explanation seems to be sensible and the
patch looks correct in that it does what it's expected to do.

So I think you can merge this. (If someone else can confirm it more
explicitly that would be better though)

comment:4 Changed 8 years ago by jinmei

  • Owner changed from UnAssigned to jelte

comment:5 Changed 8 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

if it fails, the buildbots will tell us ;)

Thanks, merged, closing ticket.

comment:6 Changed 8 years ago by shane

  • Milestone New Tasks deleted
Note: See TracTickets for help on using tickets.