Opened 8 years ago

Closed 8 years ago

#1527 closed defect (fixed)

getifaddrs (used in perfdhcp) isn't portable

Reported by: jinmei Owned by: tomek
Priority: very high Milestone: Sprint-DHCP-20111230
Component: dhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

It fails to compile on our solaris buildbot:
http://git.bind10.isc.org/~tester/builder//BIND10/20111222192001-Solaris10-sparc-GCC/logs/build.out

I temporarily prevented it from building (commit 7017367) since it's
an independent optional tool. Please update the branch so that it
will at least be selectively built (skipping platforms that don't have
getifaddrs).

Observing DHCP related code tends to cause portability regressions,
I'd also suggest regularly running buildbots for the development
branch or at least check if it's build on solaris and some flavor of
BSD by hand.

Subtickets

Change History (6)

comment:1 Changed 8 years ago by jinmei

I also noticed we should have removed perfdhcp/Makefile from
AC_CONFIG_FILES to make ./configure successful. I made the change
and committed/pushed it (67ebd76).

comment:2 Changed 8 years ago by stephen

  • Owner set to stephen
  • Status changed from new to assigned

comment:3 Changed 8 years ago by stephen

  • Owner changed from stephen to UnAssigned
  • Status changed from assigned to reviewing

Have included a stub main() in perfdhcp that gets compiled if getifaddrs() is not available and prints out a message about perfdhcp not being support on that operating system.

Last edited 8 years ago by stephen (previous) (diff)

comment:4 Changed 8 years ago by tomek

  • Owner changed from UnAssigned to stephen

Posted comment to wrong ticket. Sorry.

Last edited 8 years ago by tomek (previous) (diff)

comment:5 Changed 8 years ago by tomek

  • Owner changed from stephen to tomek

comment:6 Changed 8 years ago by tomek

  • Resolution set to fixed
  • Status changed from reviewing to closed

Changes are ok. Pushed to master.

Note: as this is fix for perfdhcp that was not released (it was merged recently and is not part of any release yet), there is no need for ChangeLog?.

Closing ticket.

Note: See TracTickets for help on using tickets.