Opened 8 years ago

Closed 8 years ago

#1520 closed defect (fixed)

bindctl config show all errors about optional parameter

Reported by: jreed Owned by: jelte
Priority: low Milestone: Sprint-20120515
Component: ~bind-ctl (obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

> config show all
Error: Boss/components/setuid/params not found
> 

Subtickets

Change History (9)

comment:1 Changed 8 years ago by shane

  • Milestone changed from New Tasks to Year 3 Task Backlog

comment:2 Changed 8 years ago by jreed

That component is gone now, but maybe issue still exists?

comment:3 Changed 8 years ago by jaspain

As shown in the bindctl session output below, this problem does still exist in bind10-devel-20120329 and is more general than suggested by the above. It appears that most or all of the Boss components have configuration objects named Boss/components/b10-<module>/params and that these are all of type list. None of these can be displayed by config show all. The error message Error: Boss/components/b10-<module>/params not found is produced. The commands config show all Boss/components/b10-<module> and config show Boss/components/b10-<module>/params also fail with the same error. Note that in my installation the varioius bind10 modules are running as user bind. I have not yet tested this running them as root. I started this test using a clean installation of bind10-devel-20120329 with no configuration changes made beforehand.

root@ns0:~# bindctl
["login success "] login as root
> config show all                                 
Error: Boss/components/b10-xfrin/params not found
> config show Boss/components/b10-xfrin           
Boss/components/b10-xfrin/special       null    string
Boss/components/b10-xfrin/process       null    string
Boss/components/b10-xfrin/kind  "dispensable"   string  (default)
Boss/components/b10-xfrin/address       "Xfrin" string  (default)
Boss/components/b10-xfrin/params/       list
Boss/components/b10-xfrin/priority      null    integer
> config show Boss/components/b10-xfrin/params
Error: Boss/components/b10-xfrin/params not found
> config remove Boss/components b10-xfrin
> config remove Boss/components b10-zonemgr
> config commit
> config show all
Error: Boss/components/b10-xfrout/params not found
> config show Boss/components/b10-xfrout
Boss/components/b10-xfrout/special      null    string
Boss/components/b10-xfrout/process      null    string
Boss/components/b10-xfrout/kind "dispensable"   string
Boss/components/b10-xfrout/address      "Xfrout"        string
Boss/components/b10-xfrout/params/      list
Boss/components/b10-xfrout/priority     null    integer
> config show Boss/components/b10-xfrout/params
Error: Boss/components/b10-xfrout/params not found
> config remove Boss/components b10-xfrout
> config commit
> config show all
Error: Boss/components/b10-stats-httpd/params not found
> config show Boss/components/b10-stats-httpd
Boss/components/b10-stats-httpd/special null    string
Boss/components/b10-stats-httpd/process null    string
Boss/components/b10-stats-httpd/kind    "dispensable"   string
Boss/components/b10-stats-httpd/address "StatsHttpd"    string
Boss/components/b10-stats-httpd/params/ list
Boss/components/b10-stats-httpd/priority        null    integer
> config show Boss/components/b10-stats-httpd/params
Error: Boss/components/b10-stats-httpd/params not found
> config remove Boss/components b10-stats-httpd
> config commit
> config show all
Error: Boss/components/b10-auth/params not found
> config show Boss/components/b10-auth
Boss/components/b10-auth/special        "auth"  string
Boss/components/b10-auth/process        null    string
Boss/components/b10-auth/kind   "needed"        string
Boss/components/b10-auth/address        null    string
Boss/components/b10-auth/params/        list
Boss/components/b10-auth/priority       null    integer
> config show Boss/components/b10-auth/params
Error: Boss/components/b10-auth/params not found
> config remove Boss/components b10-auth
> config commit
> config show all
Error: Boss/components/b10-stats/params not found
> config show Boss/components/b10-stats
Boss/components/b10-stats/special       null    string
Boss/components/b10-stats/process       null    string
Boss/components/b10-stats/kind  "dispensable"   string
Boss/components/b10-stats/address       "Stats" string
Boss/components/b10-stats/params/       list
Boss/components/b10-stats/priority      null    integer
> config show Boss/components/b10-stats/params
Error: Boss/components/b10-stats/params not found
> config remove Boss/components b10-stats   
> config commit
> config show all
Error: Boss/components/b10-cmdctl/params not found
> config show Boss/components/b10-cmdctl
Boss/components/b10-cmdctl/special      "cmdctl"        string
Boss/components/b10-cmdctl/process      null    string
Boss/components/b10-cmdctl/kind "needed"        string
Boss/components/b10-cmdctl/address      null    string
Boss/components/b10-cmdctl/params/      list
Boss/components/b10-cmdctl/priority     null    integer
> config show Boss/components/b10-cmddtl/params
Error: Boss/components/b10-cmddtl/params not found
> config remove Boss/components b10-cmdctl
> config commit
> config show all
Failed to send request, the connection is closed
root@ns0:~# ps -aef | egrep 'b10|bind'
bind      1018     1  0 22:18 ?        00:00:00 /usr/bin/python3 /usr/sbin/bind10 --user=bind
root      1544  1018  0 22:18 ?        00:00:00 b10-sockcreator
bind      1552  1018  0 22:18 ?        00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-msgq
bind      1571  1018  0 22:18 ?        00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-cfgmgr
root      2113  1972  0 22:34 pts/1    00:00:00 egrep --color=auto b10|bind

comment:4 Changed 8 years ago by jaspain

The error is reproducible with all bind10 modules running as root.

root@ns0:~# ps -aef | egrep 'b10|bind'
root      2020  1964  1 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/sbin/bind10
root      2021  2020  0 23:04 pts/0    00:00:00 b10-sockcreator
root      2022  2020  0 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-msgq
root      2023  2020  0 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-cfgmgr
root      2024  2020  0 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-zonemgr
root      2025  2020  0 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-stats
root      2026  2020  0 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-xfrin
root      2027  2020  1 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-cmdctl
root      2028  2020  0 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-xfrout
root      2029  2020  1 23:04 pts/0    00:00:00 /usr/bin/python3 /usr/libexec/bind10-devel/b10-stats-httpd
root      2030  2020  0 23:04 pts/0    00:00:00 b10-auth
root      2036  1964  0 23:04 pts/0    00:00:00 egrep --color=auto b10|bind
root@ns0:~# bindctl
["login success "] login as root
> config show all
Error: Boss/components/b10-xfrin/params not found
> config show Boss/components/b10-xfrin
Boss/components/b10-xfrin/special       null    string
Boss/components/b10-xfrin/process       null    string
Boss/components/b10-xfrin/kind  "dispensable"   string  (default)
Boss/components/b10-xfrin/address       "Xfrin" string  (default)
Boss/components/b10-xfrin/params/       list
Boss/components/b10-xfrin/priority      null    integer
> config show Boss/components/b10-xfrin/params
Error: Boss/components/b10-xfrin/params not found

comment:5 Changed 8 years ago by jelte

  • Milestone changed from Year 3 Task Backlog to Sprint-20120515
  • Owner set to jelte
  • Status changed from new to assigned

Shane just requested this ticket be done now too, so i'm adding it to this sprint as well.

I think we should treat optional lists with no default (which return as null or None) as empty lists instead of an error. This would be a relatively simple change.

comment:6 Changed 8 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from assigned to reviewing

comment:7 Changed 8 years ago by shane

  • Owner changed from UnAssigned to shane
  • Status changed from reviewing to accepted

comment:8 Changed 8 years ago by shane

  • Owner changed from shane to jelte
  • Status changed from accepted to reviewing

Looks good, although we need a ChangeLog entry.

comment:9 Changed 8 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

thanks, merged, closing ticket

(changelog is

430.	[bug]		jelte
	When displaying configuration data, bindctl no longer treats
	optional list items as an error, but shows them as an empty list.
	(Trac #1520, git 0f18039bc751a8f498c1f832196e2ecc7b997b2a)

)

Note: See TracTickets for help on using tickets.