Opened 8 years ago

Closed 6 years ago

#1516 closed defect (fixed)

Add sender details when AUTH_UNSUPPORTED_OPCODE is logged

Reported by: jreed Owned by: muks
Priority: low Milestone: Sprint-20131015
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

2011-12-19 19:19:53.071 DEBUG [b10-auth.auth] AUTH_UNSUPPORTED_OPCODE unsupported opcode: UPDATE

Maybe log the source IP, port?

Subtickets

Change History (9)

comment:1 Changed 8 years ago by shane

  • Milestone changed from New Tasks to Year 3 Task Backlog

comment:2 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Owner set to UnAssigned
  • Status changed from new to reviewing

Up for review. I have verified that the source IP address and port are logged.

comment:3 Changed 6 years ago by muks

I think no ChangeLog update is necessary for this ticket too, as it adds extra information about the source. But in any case, if we want it, the ChangeLog message is:

XYZ.    [func]          muks
	b10-auth now additionally logs the source address and port when
        DNS messages with unsupported opcodes are received.
        (Trac #1516, git ...)

comment:4 Changed 6 years ago by muks

  • Summary changed from Where did AUTH_UNSUPPORTED_OPCODE come from? to Add sender details when AUTH_UNSUPPORTED_OPCODE is logged

comment:5 Changed 6 years ago by kean

  • Owner changed from UnAssigned to kean

comment:6 Changed 6 years ago by kean

  • Owner changed from kean to muks

According to http://bind10.isc.org/wiki/CodingGuidelines#TabsIndentation arguments to functions are supposed to line up under the opening parenthesis. The change on line 587 breaks that rule. I committed b00635a to fix that. If that is acceptable please merge and close.

comment:7 Changed 6 years ago by muks

  • Owner changed from muks to kean

What you have aligned is not an argument to that macro, but is outside that macro call. It seems the previous alignment was fine.

comment:8 Changed 6 years ago by kean

  • Owner changed from kean to muks

Ok in that case please revert the commit and merge and close.

comment:9 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 71611831f6d1aaaea09143d4837eddbd1d67fbf4:

* 5c98526 Revert "[1516] Fixed function argument indentation."
* b00635a [1516] Fixed function argument indentation.
* 5017a99 [1516] Add sender details when AUTH_UNSUPPORTED_OPCODE is logged

Resolving as fixed. Thank you for the reviews Kean.

Note: See TracTickets for help on using tickets.