Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1510 closed task (complete)

Remove the -u parameter from auth and resolver

Reported by: vorner Owned by: vorner
Priority: very high Milestone: Sprint-20120110
Component: ~Boss of BIND (obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket: Socket creator
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 1 Internal?: no

Description

After the #805 and #1508 tickets are done, boss won't run as root at the time the resolver or authoritative servers are started. Therefore the -u flag shouldn't be called by the boss (the call should be removed from start_resolver and start_auth methods) and the flags should be dropped from the auth and resolver programs.

Subtickets

Change History (16)

comment:1 Changed 8 years ago by jelte

Here we run into an interesting edge of the 'no code that is not used' case. Such handling will be deprecated, but will very probably at some point in the future be necessary again (assuming standalone modules is still a long-term goal). Not that we then shouldn't put the actual handling of such things into a module-utility-lib, but still. So code that is not dead, but not used. In a state of torpor, as it were.

Just mentioning it, probably still better to remove it for now.

comment:2 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 3

comment:3 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20120110

comment:4 Changed 8 years ago by jelte

  • Priority changed from major to blocker

comment:5 Changed 8 years ago by vorner

  • Owner set to vorner
  • Status changed from new to accepted

comment:6 Changed 8 years ago by vorner

  • Owner changed from vorner to UnAssigned
  • Status changed from accepted to reviewing

Hello

It is ready for review. The code got removed (and the corresponding tests, where they were), with the documentation for the flags.

I would like it to be merged together with #805, #1508 and #1509.

I'd give it this changelog entry:

[func]*		vorner
Due to the socket creator changes, b10-auth and b10-resolver are no longer
needed to start as root. They are started as the user they should be running,
so they no longer have the -u flag for switching the user after initialization.

comment:7 Changed 8 years ago by kevin_tes

  • Owner changed from UnAssigned to kevin_tes

comment:8 Changed 8 years ago by kevin_tes

Hello vorner,

All seems ok to me except that: do we need to remove the associated description in such file "b10-auth.8" " b10-resolver.8"?

comment:9 Changed 8 years ago by kevin_tes

  • Owner changed from kevin_tes to vorner

comment:10 follow-up: Changed 8 years ago by vorner

  • Owner changed from vorner to kevin_tes

We don't. These are generated from the b10-auth.xml and b10-resolver.xml, which were updated. The .8 files are kept in the repo for some strange reasons. Jeremy will regenerate them before the release, which will propagate the changes to the man pages.

But if you want to be sure, I can regenerate them.

Thanks

comment:11 in reply to: ↑ 10 Changed 8 years ago by kevin_tes

Replying to vorner:

We don't. These are generated from the b10-auth.xml and b10-resolver.xml, which were updated. The .8 files are kept in the repo for some strange reasons. Jeremy will regenerate them before the release, which will propagate the changes to the man pages.

Ok, I get it.

But if you want to be sure, I can regenerate them.

Thanks

comment:12 Changed 8 years ago by kevin_tes

Hi,Vorner,all is ok to me now, please merge.

comment:13 Changed 8 years ago by kevin_tes

  • Owner changed from kevin_tes to vorner

comment:14 Changed 8 years ago by vorner

Thanks for the review, I'll hold off until the #805 is ready.

comment:15 Changed 8 years ago by vorner

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks, merged, closing.

comment:16 Changed 8 years ago by vorner

  • Total Hours changed from 0 to 1
Note: See TracTickets for help on using tickets.