Opened 8 years ago

Closed 8 years ago

#1440 closed defect (fixed)

help string for —with-botan should be more helpful

Reported by: jinmei Owned by: UnAssigned
Priority: high Milestone: Sprint-20120110
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket: none
Estimated Difficulty: 1 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

It currently reads:

  --with-botan=PATH       specify exact directory of Botan library

While this switch is actually used to look for ${cv_value}/bin/botan-config

That's confusing and indeed confused a user:
https://lists.isc.org/pipermail/bind10-users/2011-November/000104.html

Subtickets

Attachments (1)

configure.diff (475 bytes) - added by jinmei 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by shane

  • Feature Depending on Ticket set to none

comment:2 Changed 8 years ago by jinmei

  • Priority changed from critical to major

comment:3 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 1

comment:4 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20111220

comment:5 Changed 8 years ago by jinmei

We've not been good at purging defects, so I think we should at least
solve this easy one. Please review the attached diff. If it's okay
feel free to merge and close the ticket.

Changed 8 years ago by jinmei

comment:6 Changed 8 years ago by jinmei

  • Status changed from new to reviewing

comment:7 Changed 8 years ago by jelte

  • Priority changed from major to critical

comment:8 Changed 8 years ago by jreed

This patch is fine (but I didn't test). Please merge. Thanks.

comment:9 Changed 8 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

Applied the patch and merged it to master. Closing ticket.

Just wondering, should we consider making it --with-botan-config and request the full path to the botan-config script?

Note: See TracTickets for help on using tickets.