Opened 10 years ago

Closed 8 years ago

#144 closed task (wontfix)

Review: Xfrout

Reported by: zhanglikun Owned by: UnAssigned
Priority: medium Milestone:
Component: xfrout Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket:
Total Hours: Internal?: no

Description

Hi Jinmei, I plan to assign this ticket to you, then let you decide whether this feature should be included in the release on 4.19, or left the decision to jeremy .
I know the code will be changed later since it doesn't support IXFR now.

Subtickets

Change History (8)

comment:1 Changed 10 years ago by zhanglikun

  • Owner set to jinmei
  • Status changed from new to assigned

comment:2 in reply to: ↑ description Changed 10 years ago by jinmei

  • Owner changed from jinmei to zhanglikun

Replying to zhanglikun:

Hi Jinmei, I plan to assign this ticket to you, then let you decide whether this feature should be included in the release on 4.19, or left the decision to jeremy .
I know the code will be changed later since it doesn't support IXFR now.

From a quick glance there isn't much documentation.

  • at least there should be overall design description of this module
  • any class and public function/method should have their description
  • any other non trivial design choices (if any) should also be documented.

Regarding tests, do they check pathological cases (bogus request, sudden reset, any other cases that trigger an exception, etc) in addition to normal transactions?

Please make sure these prerequisites are met, then ask fore review again. At the very least documentation should be much improved so I'm giving it back to you for now.

comment:3 Changed 9 years ago by shane

  • Milestone changed from 02. Running, functional authoritative-only server to feature backlog item

We don't have time for this before the next release. Moving to backlog.

comment:4 follow-up: Changed 9 years ago by jreed

  • billable set to 0
  • Estimated Difficulty set to 0.0
  • Internal? unset

This ticket doesn't really indicate what is expected. What is this for? Maybe this ticket needs to be closed?

comment:5 in reply to: ↑ 4 Changed 9 years ago by jinmei

Replying to jreed:

This ticket doesn't really indicate what is expected. What is this for? Maybe this ticket needs to be closed?

I guess the point is xfrout is still considered an exception to "all code must be reviewed before being merged to trunk".

In that sense it's still active.

comment:6 Changed 9 years ago by jreed

  • Milestone changed from feature backlog item to y2 6 month milestone

comment:7 Changed 9 years ago by zhanglikun

  • Owner changed from zhanglikun to UnAssigned

comment:8 Changed 8 years ago by shane

  • Component changed from Unclassified to xfrout
  • Defect Severity set to N/A
  • Resolution set to wontfix
  • Status changed from assigned to closed
  • Sub-Project set to DNS

Well, xfrout has been in our release for more than a year, so I think we need to consider this work overtaken by events.

Future changes to xfrout will need to meet our coding guidelines of course.

Note: See TracTickets for help on using tickets.