Opened 10 years ago

Closed 9 years ago

#142 closed enhancement (fixed)

review: case-sensitive name compression

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone:
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Please someone review r1704. This is necessary for xfrout.
(so we'll also need to update the python binding and have xfrout use the
case-sensitive mode).

Giving this Shane as a review dispatcher.

Subtickets

Change History (3)

comment:1 Changed 10 years ago by shane

  • Owner changed from shane to each
  • Status changed from new to assigned

comment:2 follow-up: Changed 9 years ago by each

  • Owner changed from each to jinmei
  • Status changed from assigned to reviewing

Possible nit:
-/ object, which is the buffer into which the rendered data will be written.
+
/ object, which is the buffer into which the rendered %data will be written.

Is the percent sign a doxygen thing, or a typo?

The code and comments look fine otherwise.

comment:3 in reply to: ↑ 2 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to each:

Possible nit:
-/ object, which is the buffer into which the rendered data will be written.
+
/ object, which is the buffer into which the rendered %data will be written.

Is the percent sign a doxygen thing, or a typo?

The code and comments look fine otherwise.

Thanks. %data is necessary to prevent doxygen from making a link to our own "data" class. The real problem is it's too generic a name, but that's a different problem, and I thought there was a plan to change it - once it's done, we can easily fix the doc by a simple grep-and-edit.

Closing.

Note: See TracTickets for help on using tickets.