Opened 10 years ago

Closed 10 years ago

#141 closed defect (fixed)

review: some cleanups and minor bug fixes for xfrout

Reported by: jinmei Owned by: zhanglikun
Priority: low Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Please review r1694. See commit log for details.

Giving it to likun.

Subtickets

Change History (5)

comment:1 Changed 10 years ago by jinmei

and please also review r1695.

comment:2 Changed 10 years ago by shane

Likun can you please have a look? Thanks!

comment:3 follow-up: Changed 10 years ago by zhanglikun

  • Owner changed from zhanglikun to jinmei
  • Status changed from new to assigned

Hi Jinmei, I have reviewed the change you did, thank for you fix. I find some functions in lib/xfr/fd_share.cc is changed like:
int
recv_fd(const int sock) {

.....

}
Is this style recommended in our document? I remember you had sent one email talking about this.

comment:4 in reply to: ↑ 3 Changed 10 years ago by jinmei

  • Owner changed from jinmei to zhanglikun

Replying to zhanglikun:

Hi Jinmei, I have reviewed the change you did, thank for you fix. I find some functions in lib/xfr/fd_share.cc is changed like:
int
recv_fd(const int sock) {

.....

}
Is this style recommended in our document? I remember you had sent one email talking about this.

I'm not sure which part of the style you're asking but please first go through the coding guidelines: http://bind10.isc.org/wiki/CodingGuidelines

and if you are still not sure please ask again with clarifying exactly which part you don't understand.

Oh, btw, if we follow the guideline, recv_fd would have to be recvFD or recvFd (maybe the former is better since "FD" is a kind of acronym).

comment:5 Changed 10 years ago by zhanglikun

  • Resolution set to fixed
  • Status changed from assigned to closed

Yeah, I realize the mistake I made after reading the coding guide again. Thanks for you hint.

Note: See TracTickets for help on using tickets.