Opened 10 years ago

Closed 10 years ago

#140 closed enhancement (fixed)

review: keep stderr open for child processes if -v is specified.

Reported by: jinmei Owned by: jinmei
Priority: low Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Please review r1690.

I often found it incovenient for debugging that stderr was closed in b10-xxx child processes. This patch fixes this problem.

(This diff contains an unrelated, minor editorial fix in a comment line)

Giving this to Shane.

Subtickets

Change History (4)

comment:1 follow-up: Changed 10 years ago by shane

  • Owner changed from shane to jinmei
  • Status changed from new to assigned

The ProcessInfo? class is self-contained, so should probably not reference the global options variable. I would rather see a new argument on the constructor which says whether to redirect stderr or not and use that.

comment:2 in reply to: ↑ 1 Changed 10 years ago by jinmei

  • Owner changed from jinmei to shane

Replying to shane:

The ProcessInfo? class is self-contained, so should probably not reference the global options variable. I would rather see a new argument on the constructor which says whether to redirect stderr or not and use that.

Fair enough. How about r1698?

comment:3 follow-up: Changed 10 years ago by shane

  • Owner changed from shane to jinmei

Okay, looks good. Consider this reviewed and approved.

comment:4 in reply to: ↑ 3 Changed 10 years ago by jinmei

  • Resolution set to fixed
  • Status changed from assigned to closed

Replying to shane:

Okay, looks good. Consider this reviewed and approved.

Thanks. Closing.

Note: See TracTickets for help on using tickets.