Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1398 closed task (wontfix)

refactor _reply_xfrout_query

Reported by: jinmei Owned by:
Priority: high Milestone:
Component: xfrout Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This is a follow up task of #1371/#1372. Now we have various types
of xfr response stream (AXFR, incremental IXFR, single SOA as a
special case of IXFR), it would be cleaner if we could generalize
these cases and make _reply_xfrout_query() agnostic about the stream
types.

For example, we can introduce a new base class XfrStream? (tentatively
named) and define subclasses corresponding to the stream types.
Each subclass knows special handling (whether or not to skip SOA, etc)
specific to the types. _reply_xfrout_query() itself simply takes
an XfrStream? object and creates messages from the stream unconditionally.

I wanted to introduce this type of cleanup in #1371, but didn't choose
it in that ticket to keep the diff minimize.

Subtickets

Change History (4)

comment:1 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 5

comment:2 Changed 8 years ago by jinmei

This proposal didn't seem to be that convincing for others.

I'll withdraw the ticket at this time.

comment:3 Changed 8 years ago by jinmei

  • Milestone changed from Year 3 Task Backlog to New Tasks
  • Resolution set to wontfix
  • Status changed from new to closed

comment:4 Changed 8 years ago by shane

  • Milestone New Tasks deleted
Note: See TracTickets for help on using tickets.