#1392 closed defect (fixed)
cleanup: remove workaround in Makefile.am for isc.log
Reported by: | jinmei | Owned by: | UnAssigned |
---|---|---|---|
Priority: | medium | Milestone: | Sprint-20120306 |
Component: | build system | Version: | |
Keywords: | Cc: | ||
CVSS Scoring: | Parent Tickets: | ||
Sensitive: | no | Defect Severity: | N/A |
Sub-Project: | Core | Feature Depending on Ticket: | |
Estimated Difficulty: | 2 | Add Hours to Ticket: | 0 |
Total Hours: | 0.1 | Internal?: | no |
Description
I believe we should now remove this hack in src/lib/python/isc/log/Makefile.am:
# We're going to abuse install-data-local for a pre-install check. # This is to be considered a short term hack and is expected to be removed # in a near future version. install-data-local: if test -d @pyexecdir@/isc/log; then \ echo "@pyexecdir@/isc/log is deprecated, and will confuse newer versions. Please (re)move it by hand."; \ exit 1; \ fi
Subtickets
Attachments (1)
Change History (10)
comment:1 Changed 8 years ago by jelte
- Estimated Difficulty changed from 0 to 2
comment:2 Changed 8 years ago by jinmei
- Milestone changed from Year 3 Task Backlog to Next-Sprint-Proposed
comment:3 Changed 8 years ago by jelte
- Milestone changed from Next-Sprint-Proposed to Sprint-20120306
Changed 8 years ago by jinmei
comment:4 Changed 8 years ago by jinmei
comment:5 Changed 8 years ago by jinmei
- Status changed from new to reviewing
comment:6 follow-up: ↓ 7 Changed 8 years ago by jreed
It is fine with me to remove the hack now.
(Maybe with new hacks in comments we should add ticket number and a date.)
comment:7 in reply to: ↑ 6 Changed 8 years ago by jinmei
Replying to jreed:
It is fine with me to remove the hack now.
(Maybe with new hacks in comments we should add ticket number and a date.)
Okay, thanks, removed it. Closing ticket.
comment:8 Changed 8 years ago by jinmei
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed 8 years ago by jinmei
- Total Hours changed from 0 to 0.1
Note: See
TracTickets for help on using
tickets.
Please review the attached patch. It's super trivial.
I confirmed it didn't cause any disruption on make/make install.