Opened 8 years ago

Closed 8 years ago

#1376 closed task (complete)

update xfrin to install diffs

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: Sprint-20111122
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 1.67 Internal?: no

Description

should be a trivial task, but is a necessary step.

Subtickets

Change History (9)

comment:1 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 2

comment:2 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20111122

comment:3 Changed 8 years ago by jinmei

  • Owner set to jinmei
  • Status changed from new to accepted

comment:4 Changed 8 years ago by jinmei

trac1376 is ready for review.

I believe this is a straightforward change.

One possible point to discuss is that it doesn't work with older
versions of sqlite3 database files (which don't have the "diffs"
table). I think we should discuss how to handle this in bind10-dev.

The tentative proposed changelog entry is this:

320.?	[func]*		jinmei
	b10-xfrin now installs IXFR differences into the underlying data
	source (if it supports journaling) so that the stored differences
	can be used for subsequent IXFR-out transactions.
	Note: this is a backward incompatibility change for older sqlite3
	database files.  They need to be upgraded to have a "diffs" table.
	(Trac #1376, git TBD)

comment:5 Changed 8 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from accepted to reviewing

comment:6 Changed 8 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:7 follow-up: Changed 8 years ago by stephen

  • Owner changed from stephen to jinmei

Reviewed commit 170936d47b2e9ad3d5c3ceabf86026fca9795150

src/lib/python/isc/xfrin/libxfrin_messages.mes
Fixed a couple of typos and changed the phrasing. The resulting change has been pushed.

If you agree with the change, the branch can be merged.

comment:8 in reply to: ↑ 7 Changed 8 years ago by jinmei

Replying to stephen:

Thanks for the review.

Reviewed commit 170936d47b2e9ad3d5c3ceabf86026fca9795150

src/lib/python/isc/xfrin/libxfrin_messages.mes
Fixed a couple of typos and changed the phrasing. The resulting change has been pushed.

If you agree with the change, the branch can be merged.

The suggested changes look fine, merge done, closing.

comment:9 Changed 8 years ago by jinmei

  • Resolution set to complete
  • Status changed from reviewing to closed
  • Total Hours changed from 0 to 1.67
Note: See TracTickets for help on using tickets.