Opened 10 years ago

Closed 9 years ago

#137 closed enhancement (fixed)

review: some cleanups for xfrin

Reported by: jinmei Owned by: zhanglikun
Priority: medium Milestone:
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket:
Total Hours: Internal?: no


Please someone review r1684. As noted in the commit log, this eliminated code redundancy due to AXFRInDB (btw this class name wasn't good because it had nothing to with (A)XFR in itself).

The behavior should be generally kept, but failure mode can be different, especially when sqlite3.load() raises an exception. But I suspect the axfrin code should generally be naive about exception handling and this should be revisited anyway.

I'm not sure who's the best person as a reviewer, but giving it to likun as an initial guess.


Change History (4)

comment:1 Changed 10 years ago by jinmei

  • Type changed from defect to task

(it's not necessarily a defect, so changed the type, although "task" is probably not a good category for this)

comment:2 Changed 10 years ago by zhanglikun

  • Owner changed from zhanglikun to each
  • Status changed from new to assigned

Thank you Jinmei for your changes, I have reviewed the code just now, it looks cool. Will Evan complain?, no, no, sqlite3_ds.load() is only used for my loadzone, :). Anyway, sqlite3 datasource backend should be designed properly later, since it doesn't support cocurrent write operation(Can we support it?). Currently we can't do xfrin for two zones at the same time.), this will also be a problem for Update/IXFR in. So I plan to reassign this ticket to Evan to have a look.

comment:3 Changed 10 years ago by zhanglikun

  • Component changed from Unclassified to data source
  • Owner changed from each to zhanglikun
  • Type changed from task to enhancement

Depends on datasource. Instead of through datasource API, XFROUT write zone data with sqlite3.load()(the interface used by Loadzone). When datasource API finish, this ticket should be revisited.

comment:4 Changed 9 years ago by zhanglikun

  • billable set to 0
  • Estimated Difficulty set to 0.0
  • Internal? unset
  • Resolution set to fixed
  • Status changed from assigned to closed

Close this ticket, since the datasource code is being refactored now.

Note: See TracTickets for help on using tickets.