Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1358 closed defect (fixed)

Badpacket tool broken due to logging

Reported by: vorner Owned by: vorner
Priority: medium Milestone: Sprint-20111206
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: DNS Feature Depending on Ticket: none
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This happens when I run the badpacket tool (in tests/tools):

./badpacket 
ERROR: attempt to access logging function before logging has been initialized

It should be easy to fix.

Subtickets

Change History (9)

comment:1 Changed 8 years ago by shane

  • Defect Severity changed from N/A to Low
  • Milestone changed from New Tasks to Next-Sprint-Proposed

comment:2 Changed 8 years ago by stephen

See also #1395.

comment:3 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 2

comment:4 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20111206

comment:5 Changed 8 years ago by vorner

  • Owner set to vorner
  • Status changed from new to accepted

comment:6 Changed 8 years ago by vorner

  • Owner changed from vorner to UnAssigned
  • Status changed from accepted to reviewing

Hello

After observing that it doesn't have any kind of --verbose flag or so, I added the simplest possible logging initialization. It is not tested, as that would be quite hard and we don't test this kind of initialization anywhere else.

As this is probably not used by anyone (not even us much), I don't think we want to spam the changelog.

Thanks

comment:7 Changed 8 years ago by jelte

  • Owner changed from UnAssigned to vorner

looks fine to me, please merge.

comment:8 Changed 8 years ago by vorner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Thanks, merged.

comment:9 Changed 8 years ago by shane

  • Feature Depending on Ticket set to none
Note: See TracTickets for help on using tickets.