Opened 8 years ago

Closed 8 years ago

#1346 closed defect (complete)

unit tests for in memory datasource should be re-enabled

Reported by: jinmei Owned by: jelte
Priority: medium Milestone: Sprint-20111122
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 4 Add Hours to Ticket: 2
Total Hours: 0 Internal?: no

Description

It's now disabled, probably due to the introduction of dynamically
loadable data source modules. We should re-enable the tests.

Subtickets

Change History (10)

comment:1 Changed 8 years ago by jelte

  • Add Hours to Ticket changed from 0 to 4

comment:2 Changed 8 years ago by jelte

  • Add Hours to Ticket 4 deleted
  • Estimated Difficulty changed from 0 to 4

comment:3 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to New Tasks

comment:4 Changed 8 years ago by jinmei

  • Milestone changed from New Tasks to Next-Sprint-Proposed

comment:5 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20111122

comment:6 Changed 8 years ago by jelte

  • Owner set to UnAssigned
  • Status changed from new to reviewing

Found out i needed this before i could finish the in-memory part of 1384.

Split up the unit tests for data source into 3 separate run binaries, 'basic' tests, tests for sqlite3 and tests for in-mem. Technically, we could move one of them into the 'basic' tests, but this seemed cleaner.

comment:7 Changed 8 years ago by jelte

  • Add Hours to Ticket set to 2

comment:8 Changed 8 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:9 Changed 8 years ago by stephen

  • Owner changed from stephen to jelte

Reviewed commit cb74737554ee7e1bc3f03fc4112dee0d2b64d174

Seems OK. Please merge.

comment:10 Changed 8 years ago by jelte

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks, merged.

Note: See TracTickets for help on using tickets.